Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to get access to the http response code on GetObject #113

Open
robacarp opened this issue Mar 13, 2024 · 1 comment
Open

Ability to get access to the http response code on GetObject #113

robacarp opened this issue Mar 13, 2024 · 1 comment

Comments

@robacarp
Copy link

robacarp commented Mar 13, 2024

Thank you for this shard! I'm using it on https://archive.fm/ and it's working great.

I'd like to be able to ask if a GetObject request is successful or not. HTTP::Client::Response provides both #success? and #status_code / #status. At a bare minimum, it would be sufficient to just provide an accessor for the http response itself within GetObjectOutput.

What do you think? I'll be happy to submit a PR if you think it's worthwhile to add.

@taylorfinnell
Copy link
Owner

Makes sense to me, feel free to send an MR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants