Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path to Stage 4! #7

Open
16 of 22 tasks
ljharb opened this issue Jun 11, 2024 · 8 comments
Open
16 of 22 tasks

Path to Stage 4! #7

ljharb opened this issue Jun 11, 2024 · 8 comments

Comments

@ljharb
Copy link
Member

ljharb commented Jun 11, 2024

Stage 4

  • committee approval
  • two implementations
  • significant in-the-field experience
  • ecma262 PR approved
  • prepare ecma262 PR

Stage 3

  • committee approval
  • merge test262 tests
  • write test262 tests (PR)

Stage 2.7

Stage 2

  • committee approval
  • spec reviewers selected
  • spec text written

Stage 1

  • committee approval
@michaelficarra
Copy link
Member

@ljharb In the other places we pierce proxies, we call ValidateNonRevokedProxy in your step 3a. We may as well follow that pattern.

On the question of proxy piercing, this would make Object.prototype.toString conflict with Error.isError (since only isError will pierce), unlike Array.isArray which pierces in both places. I don't think that's a good idea.

@ljharb
Copy link
Member Author

ljharb commented Jul 11, 2024

ah, good point. That might be another very strong argument for #8 to not pierce proxies.

@ljharb
Copy link
Member Author

ljharb commented Aug 27, 2024

ping @chicoxyzzy @bakkot @michaelficarra for review, i'm going for 2.7 at the next plenary

@michaelficarra
Copy link
Member

LGTM. Is the separate AO necessary? I would inline it.

@ljharb
Copy link
Member Author

ljharb commented Aug 27, 2024

It's not necessary right now (now that the proxy piercing is gone), but future proposals will make use of it. It'd be fine to extract it at that time, instead, if you prefer.

@bakkot
Copy link

bakkot commented Aug 27, 2024

LGTM though I would want something whatwg/webidl#1421 to be at least approved in principle as well. The process doesn't currently have a stage for which "necessary host integration work is done" is an entry requirement, but either 2.7 or 3 seem appropriate. (If you want to make the case that it can happen between 2.7 and 3 that's fine by me also.)

@ljharb
Copy link
Member Author

ljharb commented Aug 27, 2024

Thanks! I agree that it must be approved before 3; and I'm hoping it will be approved before 2.7, but I also agree that it needn't block 2.7 as long as there's no feedback requiring a different direction.

@chicoxyzzy
Copy link
Member

LGTM

ljharb added a commit to tc39/test262 that referenced this issue Oct 15, 2024
ljharb added a commit to tc39/test262 that referenced this issue Oct 15, 2024
ptomato pushed a commit to tc39/test262 that referenced this issue Oct 15, 2024
ptomato pushed a commit to tc39/test262 that referenced this issue Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants