Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Disabling Redirects #20

Open
bflad opened this issue Apr 14, 2020 · 1 comment
Open

Support for Disabling Redirects #20

bflad opened this issue Apr 14, 2020 · 1 comment

Comments

@bflad
Copy link

bflad commented Apr 14, 2020

Description

Hi there 👋 This project looks pretty neat, especially from its usage in markdown-lint-check 🎉

We are investigating the possibility of using markdown-lint-check via GitHub Actions to replace some wget link checking we have, but we have an interesting feature request. Currently this library hardcodes the acceptable redirects at (a maximum) of 8:

maxRedirects: 8,

In our project documentation, we are dealing with an upstream documentation website that will sometimes move pages, but not setup proper redirects (instead all broken links just go to the homepage). Example pull request to fix some of these: https://github.com/terraform-providers/terraform-provider-aws/pull/12803/files

We are thinking that if we could configure the acceptable redirects to 0, then we could alert on those types of broken links.

Proposal

It would be super neat if this library supported configuring maxRedirects (especially to 0 in our case).

Please let me know if you have questions or if I can help contribute. 👍

@NicolasMassart
Copy link
Contributor

NicolasMassart commented Sep 23, 2020

Please let me know if you have questions or if I can help contribute.

Hi @bflad yes you can contribute of course. If you have an idea about implementing this, you can propose a pull request on this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants