Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color Theme doesn't match app theme #7

Open
sfc-gh-pkommini opened this issue Sep 29, 2023 · 8 comments
Open

Color Theme doesn't match app theme #7

sfc-gh-pkommini opened this issue Sep 29, 2023 · 8 comments

Comments

@sfc-gh-pkommini
Copy link

image

@koenvo @koenvossen

I think the way to fix maybe here: https://docs.streamlit.io/library/components/components-api#working-with-themes
@koenvo
Copy link
Contributor

koenvo commented Nov 16, 2023

Can you check #13 ?

The 'working-with-themes' page didn't work as those css variables aren't available

@webcoderz
Copy link

also ability to add bakground from url via css would be nice

@Dan-Yaw
Copy link

Dan-Yaw commented Jan 23, 2024

@koenvo Can someone approve the PR for this? I just reviewed, all looks good to me, and I need this for an application I'm working on

@sfc-gh-pkommini
Copy link
Author

lgtm. @koenvo Please merge when possible.

@bbaros
Copy link

bbaros commented Jan 26, 2024

This has been merged. Any feedback if it is working as expected? Can we get a new pip package?

@Dan-Yaw
Copy link

Dan-Yaw commented Jan 26, 2024

Looks good, thanks!

@sfc-gh-pkommini
Copy link
Author

Yes. @bbaros Please go ahead and create a pypi release 👍

@koenvo
Copy link
Contributor

koenvo commented Jan 26, 2024

Let me release a new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bbaros @koenvo @webcoderz @sfc-gh-pkommini @Dan-Yaw