Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support display: grid #15

Open
techniq opened this issue Aug 20, 2018 · 1 comment
Open

Support display: grid #15

techniq opened this issue Aug 20, 2018 · 1 comment

Comments

@techniq
Copy link
Owner

techniq commented Aug 20, 2018

Hopefully will allow support for maxHeight use cases, and should also improve rendering of position: sticky (borderBottom, etc)

@techniq
Copy link
Owner Author

techniq commented Dec 30, 2018

Hopeful improvements over table

  • Better position: sticky support (not limited to td?)
    • Support position: sticky with overflow?
    • Better support for table borders not being scrolled off
  • Should support better responsive layouts, even without media queries

Concerns

  • Limited use of built-in Material-UI styles
    • To support still using TableHead, TableBody, TableRow, need to use display: contents which has similar support as grid, but not perfect. Using display: contents also causes some styling issues itself since it makes these elements "pass through". For example, no height is passed from TableRow, and using rowProps, bodyRowProps, headerRowProps doesn't really do anything in this fashion
  • No support for row hovering using :hover but should be able to support isCellHovered or leverage display: contents solution
  • Since we're back to just individual cells, feels a little like react-virtualized-table, although we can still leverage CSS more (grid is more flexible for layout than getWidth function from before, position: sticky, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant