Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to SDKMAN too! #2499

Closed
aadrian opened this issue Dec 12, 2018 · 12 comments
Closed

Publish to SDKMAN too! #2499

aadrian opened this issue Dec 12, 2018 · 12 comments

Comments

@aadrian
Copy link

aadrian commented Dec 12, 2018

Please trigger the publish of v2.8.2 to SDKMAN too !
https://sdkman.io/sdks

Thank you.

@sarevok-anchev
Copy link

+1

@technomancy
Copy link
Owner

Thanks, but this bug tracker is for issues with Leiningen, not for 3rd-party distributions.

@marc0der
Copy link

This is in fact an issue on your side so please consider re-opeing this issue.

Sometime ago I issued API credentials to your team for publishing to SDKMAN via our Vendor API. Only one version was ever published, namely 2.7.1. Since then, the archives have been completely inconsistent and don't follow the standard SDK archive format (with bin folder etc) like all other Java/JVM SDKs do.

I would like to see the archives built in a consistent manner, and secondly would love to see you publishing all your releases to SDKMAN as many people are asking for them.

You have a great piece of software here, and I'm giving you a free channel to distribute it. Remember that SDKMAN is completely free and open source. I'd love to help you get this going again. Please shout if I can help in any way to make it happen.

@technomancy
Copy link
Owner

technomancy commented Jan 27, 2019 via email

@marc0der
Copy link

For more background about what happened, you can trace it back in issue #2204.

@winks
Copy link
Collaborator

winks commented Jan 27, 2019

Not promising anything but I'll try to have a look next week, maybe we can get it up and running again - I'm doing chocolatey on new releases anyway.

@winks
Copy link
Collaborator

winks commented Feb 15, 2019

Sorry, this took a little longer, but 2.9.0 is now on sdkman and we should be able to do this close to the release in the future - https://github.com/leiningen/leiningen-sdkman

@aadrian
Copy link
Author

aadrian commented Feb 15, 2019

@wilkes thank you very much. This looks great! The chocolatey version is also very useful !

@technomancy
Copy link
Owner

Nice work! Any chance we could get bin/lein-skdman into that repo too as per #2346 ?

@winks
Copy link
Collaborator

winks commented Feb 15, 2019

Yes, tracked at leiningen/leiningen-sdkman#1 - but I think we should doublecheck that lein and lein-sdkman didn't diverge too much, that will be a bit of work. Right now I fear it will drift even further if it's spun out.

@technomancy
Copy link
Owner

It might be best if the sdkman repo contains a patch which gets applied to the upstream bin/lein script instead? That way you get most of the changes for free, and if there is a conflict then the patch won't apply and you should notice. That's the strategy that Debian takes.

@marc0der
Copy link

@winks Thanks so much for getting it out there for everyone to use. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants