diff --git a/pkg/cmd/pipeline/start.go b/pkg/cmd/pipeline/start.go index 6c88d6a1ac..33e564bffc 100644 --- a/pkg/cmd/pipeline/start.go +++ b/pkg/cmd/pipeline/start.go @@ -19,6 +19,7 @@ import ( "encoding/json" "errors" "fmt" + "knative.dev/pkg/apis" "net/http" "os" "strings" @@ -414,7 +415,22 @@ func (opt *startOptions) startPipeline(pipelineStart *v1beta1.Pipeline) error { Params: opt.cliparams, AllSteps: false, } - return prcmd.Run(runLogOpts) + if err = prcmd.Run(runLogOpts); err != nil { + return err + } + + // Fetch the PipelineRun to get the PipelineRun status + prLatest, err := pipelinerun.GetPipelineRun(pipelineRunGroupResource, cs, prCreated.Name, prCreated.Namespace) + if err != nil { + return err + } + + // If PipelineRun status is not Succeeded, print the PipelineRun status + if prLatest.Status.GetCondition(apis.ConditionSucceeded).IsFalse() { + return errors.New(fmt.Sprintf("Pipelinerun %s did not succeed", prLatest.Name)) + } + + return nil } func (opt *startOptions) getInput(pipeline *v1beta1.Pipeline) error { diff --git a/pkg/cmd/task/start.go b/pkg/cmd/task/start.go index 6c96f93b4e..3f0f16e972 100644 --- a/pkg/cmd/task/start.go +++ b/pkg/cmd/task/start.go @@ -425,7 +425,23 @@ func startTask(opt startOptions, args []string) error { Params: opt.cliparams, AllSteps: false, } - return taskrun.Run(runLogOpts) + + if err := taskrun.Run(runLogOpts); err != nil { + return err + } + + // fetch the taskrun again to get the latest status + trLatest, err := traction.GetTaskRun(taskrunGroupResource, cs, trCreated.Name, trCreated.Namespace) + if err != nil { + return err + } + + // check if the created taskrun succeed or not + if !trLatest.IsSuccessful() { + return errors.New(fmt.Sprintf("TaskRun %s did not succeed", trCreated.Name)) + } + + return nil } func printTaskRun(output string, s *cli.Stream, tr interface{}) error {