Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP Workflow tracking via Github Issues #594

Closed
xchapter7x opened this issue Jan 5, 2022 · 12 comments
Closed

TEP Workflow tracking via Github Issues #594

xchapter7x opened this issue Jan 5, 2022 · 12 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@xchapter7x
Copy link
Contributor

Feature request

Given A tep-notifier custom task tracking PR events on the community repo (tektoncd/plumbing#980)
When a new TEP PR is created
Then the task should automatically generate a Tracking issue in the community repo
and reference the TEP PR in the comments
and NOT hard link to the PR
and contain the TEP id in the subject
and have the tep status label applied
and have the kind/tracking-issue label applied

Use case

Problem Statement:

As a Tekton Community Member there is little visibility into which TEPs are under active development, which PRs are linked to them and any discussions around implementation or functionality.

User Scenario:

As a Tekton Community Member
I would like to be able to track the progress of a TEP through its phases of development
So that i can know what is being worked on, what is complete and generally what the state of TEPs are across the community.

@xchapter7x xchapter7x added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 5, 2022
@abayer
Copy link
Contributor

abayer commented Jan 5, 2022

Proposed workflow:

@xchapter7x
Copy link
Contributor Author

xchapter7x commented Jan 5, 2022

Sub-Feature Feature Description Owner PR Link(s) Started? (:white_large_square: / :white_check_mark: ) Done? (:white_large_square: / :white_check_mark: )
A A PR is opened to https://github.com/tektoncd/community to propose a new TEP. The TEP automation bot/custom task extracts the TEP ID, title, and authors from the PR, and creates a tracking issue for the TEP in https://github.com/tektoncd/community, assigning it to the authors of the TEP, labeling it with tep-status/new, and including a link to the TEP PR. @abayer tektoncd/plumbing#983
B A PR to https://github.com/tektoncd/community is opened or edited, and that PR includes adding or making changes to an existing TEP markdown file. If the TEP does not yet have a corresponding tracking issue, one is created as described above. Otherwise, the description of the tracking issue is updated to include a link to the relevant PR. @abayer tektoncd/plumbing#983
C A PR to https://github.com/tektoncd/community is merged, and that PR includes adding or making changes to a TEP markdown file. The bot/custom task again extracts the TEP ID, and any changes to title, authors, or status, and updates the relevant tracking issue accordingly. If the status is changing to a "terminal" status (i.e., implemented, withdrawn, or replaced), the tracking issue will be closed. @abayer tektoncd/plumbing#983
D A PR to one of the "project" repositories (i.e., https://github.com/tektoncd/pipeline, https://github.com/tektoncd/triggers, etc) is opened or edited. If the PR references a TEP, either by ID, URL to the markdown file, or the tracking issue above: the description of the tracking issue is updated to include a link to the "project" PR.
E A PR to one of the "project" repositories (i.e., https://github.com/tektoncd/pipeline, https://github.com/tektoncd/triggers, etc) is opened or edited. If the PR references a TEP, either by ID, URL to the markdown file, or the tracking issue above: A comment is added or updated (as needed) reminding that the TEP's status should be updated (see Add tep-notifier custom task to comment on PRs which should trigger TEP updates plumbing#983). @abayer tektoncd/plumbing#983

abayer added a commit to abayer/plumbing that referenced this issue Jan 6, 2022
abayer added a commit to abayer/plumbing that referenced this issue Jan 6, 2022
abayer added a commit to abayer/plumbing that referenced this issue Jan 7, 2022
abayer added a commit to abayer/plumbing that referenced this issue Jan 9, 2022
@jerop
Copy link
Member

jerop commented Jan 10, 2022

@xchapter7x @abayer this is a great idea! created an issue to track TEP-0090 before the automation is available: #601 (based on the KEP issues template)

@abayer
Copy link
Contributor

abayer commented Jan 10, 2022

@jerop Woo! Once I've got the functionality actually ready to go live, I'll update your issue to match whatever we end up landing on as the format for the auto-created/updated issue so that the bot doesn't get confused. =)

abayer added a commit to abayer/plumbing that referenced this issue Jan 10, 2022
…ssue creation

Second part of implementing tektoncd/community#594

Signed-off-by: Andrew Bayer <[email protected]>
abayer added a commit to abayer/plumbing that referenced this issue Jan 13, 2022
…ssue creation

Second part of implementing tektoncd/community#594

Signed-off-by: Andrew Bayer <[email protected]>
@xchapter7x
Copy link
Contributor Author

@abayer
what are your thoughts on a new feature here.
When the tracking issue gets created, the robot adds said issue to this project https://github.com/orgs/tektoncd/projects/5

@abayer
Copy link
Contributor

abayer commented Jan 14, 2022

@xchapter7x Sounds good!

@abayer
Copy link
Contributor

abayer commented Jan 14, 2022

Actually, I wonder if a new project would make more sense - the workflows for TEP PRs and tracking issues wouldn't quite be the same thing. I need to dig further into the projects API/functionality...

@xchapter7x
Copy link
Contributor Author

Agreed, the TEP PR (which is what is currently in the project linked above) is not the same as the Tracking Issue.
However, the project's intent is to track the state of a given TEP through its lifecycle. Which overlaps with the intent of the Tracking Issue. It might make sense moving forward, rather than tracking a closed PR, to track the tracking issues in the project.

thoughts?

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 14, 2022
@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 14, 2022
@tekton-robot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants