Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TriggerTemplates table paneling first pass #666

Closed
ncskier opened this issue Oct 25, 2019 · 3 comments
Closed

TriggerTemplates table paneling first pass #666

ncskier opened this issue Oct 25, 2019 · 3 comments
Assignees

Comments

@ncskier
Copy link
Member

ncskier commented Oct 25, 2019

This work is under epic #509

Expected Behavior

I expect to be able to view all of the TriggerTemplate resources as a table in the Dashboard.

The columns of the table must include the following information about each TriggerTemplate:

  • Name
  • Namespace

Here is the latest wireframe from #509. Since this issue is a first pass at the paneling, it will not be as sophisticated as the wireframe; the filter, checkboxes, and date modified column in the wireframe should not be included in this initial implementation.
tt-table

Actual Behavior

We have no paneling for TriggerTemplates.

Additional Info

@carlos-logro
Copy link
Contributor

/assign

@a-roberts
Copy link
Member

a-roberts commented Nov 11, 2019

@carlos-logro I'm working on the details part of this, haven't rebased to use your table yet (but that looks good to me from the PR), and I have this so far (obviously don't need last transition time), haven't implemented date modified.

image

If you've done more (this only took me < 30 minutes and I didn't implement tests) I'm happy to drop this, I basically implemented it so I could review your table and try it, then figured: actually... to implement the details task, I may as well implement this.

Either way, lemme know 😄 I'm going to add in your table component next. Branch at https://github.com/a-roberts/dashboard/tree/triggerTemplatePanelling.

@a-roberts
Copy link
Member

Merged so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants