You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a tekton contributor it's kind of hard to know which linters and which makefile rules needs to be executed before sending a Pull Request to tektoncd/pipeline
It would be great if we can standardize those rules via pre-commit which is a popular tools in opensource repositories to make sure before submitting the PR we test it locally first.
We would not need to introduce new pre-commit hooks, just have custom hooks launching the appropriate make commands which reflects what happen in CI (outer loop)
Here is an example how we do this on pipelines-as-code:
Feature request
As a tekton contributor it's kind of hard to know which linters and which makefile rules needs to be executed before sending a Pull Request to tektoncd/pipeline
It would be great if we can standardize those rules via pre-commit which is a popular tools in opensource repositories to make sure before submitting the PR we test it locally first.
We would not need to introduce new pre-commit hooks, just have custom hooks launching the appropriate make commands which reflects what happen in CI (outer loop)
Here is an example how we do this on pipelines-as-code:
https://github.com/openshift-pipelines/pipelines-as-code/blob/37ec9a9b7b1da4f6c1eba37cf94ea67d4a37594e/.pre-commit-config.yaml#L36-L70
Use case
The text was updated successfully, but these errors were encountered: