Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: remove clustertask support #8601

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cleanup: remove clustertask support #8601

wants to merge 1 commit into from

Conversation

waveywaves
Copy link
Member

@waveywaves waveywaves commented Feb 27, 2025 •
edited
Loading

Changes

remove all clustertask related code
fixes #8556

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Remove ClusterTask support completely

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesnt merit a release note. labels Feb 27, 2025
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign yongxuanzhang after the PR has been reviewed.
You can assign the PR to them by writing /assign @yongxuanzhang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot requested review from abayer and jerop February 27, 2025 17:33
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 27, 2025
@waveywaves
Copy link
Member Author

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 27, 2025
@waveywaves waveywaves marked this pull request as ready for review February 27, 2025 18:05
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 27, 2025
@waveywaves waveywaves changed the title WIP: remove ClusterTask cleanup: remove clustertask support Feb 27, 2025
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesnt merit a release note. labels Feb 27, 2025
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/apiserver/apiserver.go 98.1% 96.2% -1.9
pkg/reconciler/taskrun/resources/taskref.go 94.2% 93.9% -0.3
pkg/reconciler/taskrun/taskrun.go 86.1% 86.1% -0.1
pkg/taskrunmetrics/metrics.go 87.2% 87.0% -0.2
pkg/trustedresources/verify.go 94.0% 91.6% -2.4
test/controller.go 28.5% 29.5% 1.1

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2025
@waveywaves waveywaves force-pushed the byebyeclustertasks branch from cee55bb to c2aab0d Compare March 4, 2025 00:13
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2025
@waveywaves
cleanup: remove deprecated clustertask source
37ff332 
as clustertasks are already deprecated, this commit ensures that the implmentation
of clustertask CRD, reconciliation etc. is removed whilst ensuring that the tests
use tasks instead of clustertasks.
@waveywaves waveywaves force-pushed the byebyeclustertasks branch from c2aab0d to 37ff332 Compare March 4, 2025 00:17
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/apiserver/apiserver.go 98.1% 96.2% -1.9
pkg/reconciler/taskrun/resources/taskref.go 94.2% 93.9% -0.3
pkg/reconciler/taskrun/taskrun.go 86.1% 86.1% -0.1
pkg/taskrunmetrics/metrics.go 87.2% 87.0% -0.2
pkg/trustedresources/verify.go 94.0% 91.6% -2.4
test/controller.go 28.5% 29.5% 1.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/apiserver/apiserver.go 98.1% 96.2% -1.9
pkg/reconciler/taskrun/resources/taskref.go 94.2% 93.9% -0.3
pkg/reconciler/taskrun/taskrun.go 86.1% 86.1% -0.1
pkg/taskrunmetrics/metrics.go 87.2% 87.0% -0.2
pkg/trustedresources/verify.go 94.0% 91.6% -2.4
test/controller.go 28.5% 29.5% 1.1

@waveywaves
Copy link
Member Author

/retest

@waveywaves
Copy link
Member Author

/assign @AlanGreene

@tekton-robot
Copy link
Collaborator

@waveywaves: GitHub didn't allow me to assign the following users: AlanGreene.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @AlanGreene

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abayer abayer Awaiting requested review from abayer

@jerop jerop Awaiting requested review from jerop

@pritidesai pritidesai Awaiting requested review from pritidesai

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Tekton Community Roadmap
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove ClusterTask support
2 participants
@waveywaves @tekton-robot