Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropdownList Observable.merge unimported #1192

Closed
Zaixu opened this issue Jan 8, 2018 · 5 comments
Closed

DropdownList Observable.merge unimported #1192

Zaixu opened this issue Jan 8, 2018 · 5 comments
Assignees

Comments

@Zaixu
Copy link

Zaixu commented Jan 8, 2018

I'm submitting a...

  • Bug report

Current behavior

DropDownList component uses rxjs patching, but forgets to include "import 'rxjs/add/observable/merge" that it uses.

This will fail builds that use lettable operators.

Expected behavior

Use that import or start using lettable operators for benefits.

Minimal reproduction of the problem with instructions

It can be seen in source of the component that Observable.merge is used, but never imported.

What is the motivation or use case for changing the behavior?

Builds to work correctly without having to patch the error locally.
This is an error that first gets picked up in production builds, so only seen when already built.

@valchev
Copy link

valchev commented Jan 8, 2018

@Zaixu thank you for bringing this to our attention.
I pushed a fix for the issue, it is currently available in the latest dev build.

@ipeshev ipeshev added Passed-QA and removed Needs-QA labels Jan 9, 2018
@valchev
Copy link

valchev commented Jan 12, 2018

Latest version (1.6.0) contains the fix and is shipped.

@valchev valchev closed this as completed Jan 12, 2018
@jesulink2514
Copy link

image

I faced the same issue when the kendo dropdown is used in a lazily loaded module with Angular 5. Here is a minimal repo to reproduce the problem.

https://github.com/jesulink2514/kendo-dropdown-issue

@tsvetomir
Copy link
Member

This issue turned out to be more complicated than we initially thought. We're investigating the possible fixes. Worst case, we'll have to upgrade to the latest RxJS version with lettable operators - a breaking change for users that are still on older versions.

@tsvetomir
Copy link
Member

Tracking in #1214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants