Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astroid menu module resets after updating Astroid #854

Open
vtheod opened this issue Oct 31, 2024 · 7 comments · May be fixed by #853
Open

Astroid menu module resets after updating Astroid #854

vtheod opened this issue Oct 31, 2024 · 7 comments · May be fixed by #853
Assignees
Labels
bug Something isn't working
Milestone

Comments

@vtheod
Copy link

vtheod commented Oct 31, 2024

Describe the bug
After astroid update, the astroid menu module resets it's position from astroid header menu (or astroid header mobilemenu) to status.

To Reproduce
Steps to reproduce the behavior:
Just puplish an astroid menu module to astroid header menu or to astroid header mobilemenu positions and then update astroid to a later version.

Expected behavior
the module's position will be reset

Screenshots
Before the update:
Before_update

After the update:
After_update

System Informations (please complete the following information):

  • Joomla Version: [Joomla 4 & 5]
  • PHP Version [PHP 8.1, 8.2 & 8.3]
  • Astroid Version [e.g. Astroid 3.1.0]
  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]

Additional context
Add any other context about the problem here.

@rinka88
Copy link

rinka88 commented Oct 31, 2024

I confirm
This happens when updating a template.
When discussing 3.1.7 RC talked about this

@vtheod
Copy link
Author

vtheod commented Oct 31, 2024

This happens when updating the framework (haven't noticed it with template updates) and it's not recent but it exists also in previous versions of astroid.

@rinka88
Copy link

rinka88 commented Oct 31, 2024

This happens when updating the framework (haven't noticed it with template updates) and it's not recent but it exists also in previous versions of astroid.

by the word template I meant framework

@sonvnn
Copy link
Member

sonvnn commented Nov 1, 2024

@rinka88 @vtheod It's my mistake. I will fix it in the next version. Please wait for the update.

@sonvnn
Copy link
Member

sonvnn commented Nov 1, 2024

@vtheod @rinka88 I fixed this issue at 6f99ee7
Please help me download v3-branch and test it.

Best Regards,
Sonny

@sonvnn sonvnn added this to the Version 3.1.8 milestone Nov 1, 2024
@sonvnn sonvnn linked a pull request Nov 1, 2024 that will close this issue
@sonvnn sonvnn added the bug Something isn't working label Nov 1, 2024
@sonvnn sonvnn self-assigned this Nov 1, 2024
@sonvnn sonvnn moved this to In review in Astroid Framework Nov 1, 2024
@vtheod
Copy link
Author

vtheod commented Nov 1, 2024

I installed it and it seems that the issue is fixed. Thanks @sonvnn
I just noticed that after installation, the icon in the get started button doesn't display:

Screenshot 2024-11-01 at 09-56-50 Extensions Install - Administration

@rinka88
Copy link

rinka88 commented Nov 1, 2024

thanks for the correction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In review
Development

Successfully merging a pull request may close this issue.

3 participants