Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interceptor Configurations - exclusions based on workflow/activity type and task queue #2179

Open
tsurdilo opened this issue Aug 10, 2024 · 1 comment
Labels
enhancement User experience

Comments

@tsurdilo
Copy link
Contributor

Feature request is to be able to add configuration-based approach to exclude certain workflows and/or activities
from being intercepted based on their type or task queue they run on.

@tsurdilo tsurdilo added the enhancement User experience label Aug 10, 2024
@cretz
Copy link
Member

cretz commented Aug 12, 2024

I am not sure there is value in "configuration" in this case when it can be done in a conditional. There are theoretically infinite number of configurations to exclude things (I can think of dozens) instead of simple conditionals in an interceptor, so I think we should encourage programmatic exclusion when using programmatic interceptors. If someone wants to write an interceptor wrapper that does does exclusion check before applying inner interceptor, they can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement User experience
Projects
None yet
Development

No branches or pull requests

2 participants