Skip to content
This repository has been archived by the owner on Dec 18, 2022. It is now read-only.

Add Proper JACK Implementation #737

Open
2 tasks done
Turtley12 opened this issue Sep 18, 2022 · 0 comments
Open
2 tasks done

Add Proper JACK Implementation #737

Turtley12 opened this issue Sep 18, 2022 · 0 comments
Labels
enhancement Idea or request for new feature

Comments

@Turtley12
Copy link

Guidelines

  • I have read the guidelines.

Is your feature request related to a problem? Please describe.

The Audacity/Tenacity JACK implementation is technically functional, but it is different from most other jack clients, and as some people have described it: "A perfect example of how not to implement a jack client.

Current Behavior

When "JACK Audio Connection Kit" is selected in the Host drop-down, The recording and playback device show the clients currently connected to the jack audio server. Nothing else happens until you start recording.

When you start recording, Tenacity automatically connects to the jack clients that were selected. It is then possible to switch the connections to other ports, but since Tenacity is already recording you end up having to cut the first part of the recording and it makes it hard to record that track alongside other tracks. This makes it difficult to use Tenacity with anything more than the most basic jack setups.

Describe the solution you'd like

Expected Behavior

When "JACK Audio Connection Kit" is selected as the audio host, Tenacity should connect to jack, and register input and output ports, but it should not automatically connect to anything.
Then the user can connect Tenacity to other jack devices, and when they start recording, Tenacity will respect these connections. Same with playback.

Describe alternatives you've considered

  • Enabling "Sound Activated Recording". This gives the user more time to change the connections from what Tenacity automatically does, but it is still much more of a hassle than it should be, and it means that as soon as you connect to something it will start recording, which isn't ideal in most cases. and still isn't a proper jack implementation.

Additional context

This is a problem in the Audacity issue tracker, but the maintainers basically said it was usable how it is and they weren't going to fix it, So I created this in hope that there will be more support for a better jack implementation here.

Applicable Audacity Issues:
audacity/audacity#3553
audacity/audacity#711
audacity/audacity#710

If there is anything I can help with related to this issue, please let me know.

(This issue is a duplicate, just not a duplicate of an existing Tenacity Issue.)

This issue is not a duplicate

  • I have confirmed this issue isn't a duplicate.
@Turtley12 Turtley12 added the enhancement Idea or request for new feature label Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Idea or request for new feature
Projects
None yet
Development

No branches or pull requests

1 participant