Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong info for imagesloaded #401

Open
dsandstrom opened this issue Apr 7, 2017 · 2 comments
Open

Wrong info for imagesloaded #401

dsandstrom opened this issue Apr 7, 2017 · 2 comments

Comments

@dsandstrom
Copy link

We need to require the pkgd version, similar to #400:

//= require imagesloaded/imagesloaded.pkgd
@hut8
Copy link
Member

hut8 commented Apr 7, 2017

Can you suggest a way to programatically determine this? The only way I see is by reading the README. The bower.json specifies in "main" that imagesloaded.js (not the pkgd version) is what should be loaded. It seems like this is an unfortunate consequence of the Bower maintainer changing the meaning of the "main" key of bower.json.

@dsandstrom
Copy link
Author

dsandstrom commented Apr 7, 2017

Programmatically? A naming map maintained by rails-assets, however this is not ideal because it would have to be kept up to date. A better way would be to convince the js package maintainer to change their main key. Yet, this is not guaranteed to work. Also, I have limited experience with bower configs so not sure who is right.

A naming map might solve the "foo.js" problem because when a package ends with ".js", rails-assets shows require foo.js.js in the readme. However, this doesn't solve the css require issue because that probably changes for each package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants