Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support diff #9

Open
hhsecond opened this issue Feb 18, 2020 · 6 comments
Open

Support diff #9

hhsecond opened this issue Feb 18, 2020 · 6 comments

Comments

@hhsecond
Copy link
Member

Description

Hangar's diff is not good enough for stockroom since especially the model storage saves the weights in different arraysets/columns. Stockroom needs an abstracted diff that refines the diff data from hangar

@rlizzo
Copy link
Member

rlizzo commented Feb 19, 2020

Is this anything that could be improved on hangars end? Or is it just a detail of stockrooms implementation?

@hhsecond
Copy link
Member Author

Just on stockroom. And I think I need to refine only the model diff because of the way stockroom stores model.

@rlizzo
Copy link
Member

rlizzo commented Feb 19, 2020

Ok. Good luck!

@jjmachan
Copy link
Contributor

I would like to take up this issue. Can you provide a bit more info about this?

@hhsecond
Copy link
Member Author

Hi @jjmachan,
So the difference in diff data between hangar and stockroom is nill for data storage. But when it comes to model storage, there will be few abstractions we need to do. This is because stockroom saves model weights (for a single model) in multiple columns. So we need to collate the diff from the hangar and make high-level diff before returning to the user. Similar to that, tags in the stockroom are currently built on top of the str typed column which possesses the history. But the idea of the tag is to make the information commit level (it acts like a commit message, you checkout to another commit and you lost the tagged data). Do these make sense to you? Feel free to ask any questions if you have? And meanwhile, I'll come up with an example that should make it easy to understand

@jjmachan
Copy link
Contributor

So from what I understand tags are the most useful items for an effective diff rt? Since the diff is supposed to be read by the user the tags provide the most relevant information about the model architecture, hyperparameters, losses and accuracies etc. Those are the details that have to get reflected in the diff rt?

@jjmachan jjmachan mentioned this issue Apr 2, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants