Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup SPDX Workflow for tt-Forge repo #35

Open
staylorTT opened this issue Feb 7, 2025 · 1 comment
Open

Setup SPDX Workflow for tt-Forge repo #35

staylorTT opened this issue Feb 7, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@staylorTT
Copy link
Contributor

In preparation for demo code / other code can we get the SPDX checker setup.

Similar to https://github.com/tenstorrent/tt-forge-fe/blob/main/.github/check-spdx.yml on other repos.

This could be a good candidate for https://github.com/tenstorrent/tt-github-actions since all our open repos should be using it.

@staylorTT staylorTT added the enhancement New feature or request label Feb 7, 2025
@jmcgrathTT
Copy link

If we want this to work only in the CI by pre-downloading the check-spdx.yml from tt-github-actions, this is easy. If we want it to work locally, it's going to take some more work.

The problem is there is no arg option that will let you pull from a URL for this pre-commit hook.

https://github.com/espressif/check-copyright?tab=readme-ov-file#information-about-optional-parameters
https://github.com/tenstorrent/tt-forge-fe/blob/main/.pre-commit-config.yaml#L2-L6

In order to fix it, I would have to fork and contribute upstream.
https://github.com/espressif/check-copyright/blob/master/check_copyright.py#L573

Thoughts @vmilosevic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants