Add preprocessing of list inputs for op by op execution #300
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmanzoorTT
requested review from
AleksKnezevic,
LPanosTT,
ddilbazTT and
brataTT
|
||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
| @@ -336,6 +336,16 @@ def pre_process_inputs(self, *inputs): | |||
| if not inp.is_contiguous(): | |||
| inp = inp.contiguous() | |||
| processed_inputs.append(inp) | |||
| elif isinstance(inp, list): | |||
| for ele in inp: | |||
There was a problem hiding this comment.
can you please move this bit into a helper, and call it in both cases (i.e. if tensor or if element in list). Otherwise, looks great.
AleksKnezevic
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #301
Ticket
#301
Problem description
aten::cat (concatenate) operation is failing for op-by-op execution due to mismatch in numbers of inputs
What's changed
Inputs preprocessing for op-by-op execution is updated to process inputs of type list.
Nightly tests (https://github.com/tenstorrent/tt-torch/actions/runs/13270505478) report shows the improvement.
Checklist