Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yarn cache to workflow and make sure it's working #4

Open
godber opened this issue Jun 8, 2023 · 3 comments
Open

Add yarn cache to workflow and make sure it's working #4

godber opened this issue Jun 8, 2023 · 3 comments
Assignees

Comments

@godber
Copy link
Member

godber commented Jun 8, 2023

@jsnoble had added the yarn cache to some of his node setup actions as did I, but I thought they weren't working. I did just find some evidence of this working on the standard-assets project:

Obviously this is a feature we want, but we want to make sure we understand it well enough to use it properly, we want it to work.

@godber godber self-assigned this Jun 8, 2023
@godber
Copy link
Member Author

godber commented Jun 8, 2023

Oh, the kafka asset has caches too ...

https://github.com/terascope/kafka-assets/actions/caches

Maybe I just don't understand when the cache gets used. I had assumed, perhaps erroneously, that they were not working because of messages like this on the node setup action

Run actions/setup-node@v3
Found in cache @ /opt/hostedtoolcache/node/14.21.3/x64
Environment details
/usr/local/bin/yarn --version
1.18.0
/usr/local/bin/yarn cache dir
/home/runner/.cache/yarn/v4
yarn cache is not found

ref: https://github.com/terascope/kafka-assets/actions/runs/5147923655/jobs/9268939754

@godber
Copy link
Member Author

godber commented Jun 8, 2023

Oh, I'm confusing the tool cache with the yarn cache ... this message is about the toolcache, which is where node setup gets it's node release for a specific version

Found in cache @ /opt/hostedtoolcache/node/18.16.0/x64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant