Form Tokens von Feldern, deren Feldname auf "-suffix" o.ä. enden, werden in E-Mails nicht ersetzt!

[bildschirmartist]

Moin zusammen,
wir haben ein Problem, das seit kurzem auftritt:
Es wurde ein Formular eingerichtet, dass über notification_center eine E-Mail generiert und verschickt. Hier sind auch einige Formularfelder enthalten, deren Feldname auf -suffix endet. Beispiel:

• customer-id
• product-id
• error-message

Diese werden in den E-Mails aktuell aber nicht ersetzt, stattdessen sieht die generierte E-Mail so aus:

Als Workaround haben wir die Felder nun wie folgt umbenannt:

• customerId
• productId
• errorMessage

Damit funktioniert es für uns temporär wieder.

Beste Grüße

[bildschirmartist]

Kurze Ergänzung: Scheinbar betrifft es sämtliche Formularfelder, die ein - im Namen beinhalten

[fritzmg]

Isn't this a known limitation of simple tokens? Or do such tokens work outside of the NC?

[bildschirmartist]

Isn't this a known limitation of simple tokens? Or do such tokens work outside of the NC?

Hi @fritzmg,
thanks for your quick response.
Maybe this is a known limitation of simple tokens but it worked at least until v.2.0.9 of NC.
If it is a limitation, then this should be mentioned in the documentation when it comes to the ##form_*## Simple Token description, because it is a valid form field name.

[fritzmg]

It does look like simple tokens with - are supported in general:

// outputs "Hello World!"
$this->simpleTokenParser->parse('##foo-bar##', ['foo-bar' => 'Hello World!'])

[fritzmg]

The change was introduced in 8d4e519

[fritzmg]

@Toflar I don't think it is necessary to silently remove the characters from the variable name. It just means you cannot use it for {if …} etc. There also won't be any errors if you try.

[Toflar]

You cannot have dashes - in token names. It's forbidden. That's why the NC normalizes them to _.

[fritzmg]

@Toflar but you can. ##foo-bar## will output the content of the token. The only thing that won't work is

{if foo-bar …}

etc.

And that applies to everywhere in Contao, not just the NC.

[Toflar]

Yes, and we want unified tokens otherwise people don't understand why it works in ## but not in the {if statement. In Contao 5, using it in the {if statement with a - will cause an error. Hence, they are normalized. Just use _ instead of - and continue your day - no need to discuss this further.

[fritzmg]

In Contao 5, using it in the {if statement with a - will cause an error.

No, I just tried, it does not cause an error.

[fritzmg]

See #390

[Toflar]

I have decided to automatically generate both, normalized and original token names in version 2.2.5. This means that ##form_product-id## should now work again but if you want to use it in comparisons, you'll have to use {if form_product_id == 42}.