feat: Enhancing VPC Security with Amazon VPC Block Public Access #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, aws_vpc_block_public_access_exclusion
antonbabenko
requested changes
Jan 27, 2025
Co-authored-by: Anton Babenko <[email protected]>
Co-authored-by: Anton Babenko <[email protected]>
Co-authored-by: Anton Babenko <[email protected]>
Co-authored-by: Anton Babenko <[email protected]>
Co-authored-by: Anton Babenko <[email protected]>
Co-authored-by: Anton Babenko <[email protected]>
…cess-exclusion-1158
antonbabenko
requested changes
Jan 28, 2025
outputs.tf
Outdated
| @@ -78,6 +78,11 @@ output "vpc_owner_id" { | |||
| value = try(aws_vpc.this[0].owner_id, null) | |||
| } | |||
|
|
|||
| output "vpc_block_public_access_exclusions" { | |||
| description = "List of VPC block public access exclusions" | |||
| value = [for k, v in aws_vpc_block_public_access_exclusion.this : v.id] | |||
There was a problem hiding this comment.
Please make it as a map, not list.
There was a problem hiding this comment.
I changed this output into map.
variables.tf
Outdated
| @@ -116,6 +116,65 @@ variable "tags" { | |||
| default = {} | |||
| } | |||
|
|
|||
| variable "vpc_block_public_access_options" { | |||
| description = <<EOF | |||
There was a problem hiding this comment.
Omg, please keep the descriptions as similar to the rest of the module's variables as possible. We normally show available options in the examples or README, but not in the description.
Update the list of the examples in the README.md
There was a problem hiding this comment.
I updated README.md for new example block-public-access, list of examples in main README.md and variables descriptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR add support for VPC Block Public Access exclusions and VPC Block Public Access options
Motivation and Context
Resolves #1158
Breaking Changes
It doesn't break backwards compatibility with the current major version
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request