Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scope all auth policies to individual keys/buckets #943

Merged
merged 16 commits into from
Feb 7, 2025

Conversation

toddgiguere
Copy link
Contributor

@toddgiguere toddgiguere commented Jan 13, 2025

Description

Proposed changes to scope all of the KMS and COS auth policies to their individual targets (keys or buckets) instead of instance targets.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@toddgiguere toddgiguere changed the title [DRAFT] feat: scope all auth policies to individual keys/buckets feat: scope all auth policies to individual keys/buckets Jan 16, 2025
@toddgiguere toddgiguere marked this pull request as ready for review January 16, 2025 21:18
@toddgiguere toddgiguere requested a review from Aashiq-J as a code owner January 16, 2025 21:19
@toddgiguere
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Member

ocofaigh commented Feb 4, 2025

/run pipeline

ocofaigh
ocofaigh previously approved these changes Feb 4, 2025
@ocofaigh
Copy link
Member

ocofaigh commented Feb 5, 2025

Upgrade test needs to be skipped

SKIP UPGRADE TEST
@toddgiguere
Copy link
Contributor Author

Had committed the SKIP UPGRADE but forgot to push, running pipeline now.

@toddgiguere
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Member

ocofaigh commented Feb 5, 2025

/run pipeline

@toddgiguere
Copy link
Contributor Author

@ocofaigh I think my rescope of the auth policies has affected the vsi-extension pattern. I can't tell yet if it is the actual pattern that needs to be fixed, or if it is our test that needs to be adjusted.

The error is with flow logs not having auth to the COS bucket. I need to look at the actual test (which I think first provisions "existing resources").

@toddgiguere
Copy link
Contributor Author

/run pipeline

1 similar comment
@toddgiguere
Copy link
Contributor Author

/run pipeline

@toddgiguere
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit 9d84adc into terraform-ibm-modules:main Feb 7, 2025
2 checks passed
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants