-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: scope all auth policies to individual keys/buckets #943
feat: scope all auth policies to individual keys/buckets #943
Conversation
using fixed account id
/run pipeline |
/run pipeline |
Upgrade test needs to be skipped |
SKIP UPGRADE TEST
Had committed the SKIP UPGRADE but forgot to push, running pipeline now. |
/run pipeline |
/run pipeline |
@ocofaigh I think my rescope of the auth policies has affected the vsi-extension pattern. I can't tell yet if it is the actual pattern that needs to be fixed, or if it is our test that needs to be adjusted. The error is with flow logs not having auth to the COS bucket. I need to look at the actual test (which I think first provisions "existing resources"). |
/run pipeline |
1 similar comment
/run pipeline |
/run pipeline |
🎉 This PR is included in version 7.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Proposed changes to scope all of the KMS and COS auth policies to their individual targets (keys or buckets) instead of instance targets.
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers