Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 upload_fileobj parameter Callback doesn't support asynchronous function callbacks #356

Open
zent1n0 opened this issue Jan 24, 2025 · 1 comment · May be fixed by #357
Open

S3 upload_fileobj parameter Callback doesn't support asynchronous function callbacks #356

zent1n0 opened this issue Jan 24, 2025 · 1 comment · May be fixed by #357

Comments

@zent1n0
Copy link

zent1n0 commented Jan 24, 2025

I'm writing a small feature to provide a progress showing when uploading file onto s3. In my callback, the function writes progress to a message queue, so later the message will be sent to event stream with FastAPI StreamingResponse. The function puts message into an asyncio.Queue, therefore it must be asynchronous one.
As the module provides an asynchronous version of boto3, I guess it should be fine if we adjust the processing logic with Callback, so it could also accept a coroutine to be run nonblockingly.

@terricain
Copy link
Owner

Yeah, raise a PR and I'll have a look

@zent1n0 zent1n0 linked a pull request Jan 24, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants