Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security concerns regarding "list-keys" command #354

Open
Jan21493 opened this issue Jan 19, 2025 · 3 comments
Open

Security concerns regarding "list-keys" command #354

Jan21493 opened this issue Jan 19, 2025 · 3 comments
Labels
priority:low question Further information is requested

Comments

@Jan21493
Copy link

The "list-keys" command in tesla-control does not require any authentication over BLE, so it is possible to get the full key list from each vehicle nearby. I know that these keys are only public keys, but I also know that the effort to find / calculate a private key that is able to control the car is much lower if I know the public key. The distance with BLE is limited and the algorithms might be considered as safe, but in the future this may change.

Therefore I'm asking if there are any good reasons why the "list-keys" command does not need any authentication over BLE?

I don't see a problem with "body-controller-state" that also does not require any authentication over BLE, because if I'm only a few meters away from the car, it's easy to verify the locking state by lifting the handle. The information provided does not reveal any secrets.

@Jan21493 Jan21493 changed the title Security concerns regading list-keys Security concerns regarding "list-keys" command Jan 19, 2025
@sethterashima
Copy link
Collaborator

This isn't generally a concern; your bank and email servers send your browser their public keys every time you visit their websites, for example. But it is a good point that the command should require authentication unless there's a specific reason for it not to. I'll ask the mobile app dev team.

@thefireblade thefireblade added the question Further information is requested label Jan 24, 2025
@Jan21493
Copy link
Author

Jan21493 commented Feb 2, 2025

There is a little difference: with TLS the keys are part of a certificate that has a lifetime of typically 1 or 2 years. The keys don't have to be replaced with new certificates, but they can. I'm not sure about the estimated lifetime for the keys on the vehicles, but I think it might be 10 or 20 years.

@sethterashima
Copy link
Collaborator

A valid point, but might be worth noting that the Root CA keys typically have a much longer lifetime than leaf certificates; Google's are 20 years, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants