From 8aa35d48c3a2d1e82c593156fa1710f3bff8aa67 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 30 Sep 2024 13:18:42 +0200 Subject: [PATCH 01/24] feat: run tests on windows --- .github/workflows/build-docker-image.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index 6dd1c3f..d2696c8 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -52,10 +52,8 @@ jobs: GOOS: windows run: go build -# TODO enable tests on Windows -# Currently doesn't succeed, see https://github.com/testcontainers/testcontainers-go/issues/948 -# - name: go-test -# run: go test -v ./... + - name: go-test + run: go test -v ./... build-image-linux: runs-on: ubuntu-latest From 7ef68696dc65f22861ae09d86f5a2aef276c87c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 16:26:23 +0100 Subject: [PATCH 02/24] chore: run tests with race flag --- .github/workflows/build-docker-image.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index d2696c8..58d053a 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -53,7 +53,7 @@ jobs: run: go build - name: go-test - run: go test -v ./... + run: go test -race -v ./... build-image-linux: runs-on: ubuntu-latest From 2b36facdfc47f0b3db6b001b09a7919fd3e6515f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 16:28:13 +0100 Subject: [PATCH 03/24] chore: run windows tests in the self-hosted VM --- .github/workflows/build-docker-image.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index 58d053a..cdbca71 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -33,7 +33,7 @@ jobs: run: go test -race -v ./... test-windows: - runs-on: windows-2022 + runs-on: [self-hosted, Windows, X64] steps: - uses: actions/checkout@v4 - uses: actions/setup-go@v5 From ac0d16d84fc96f172d90da75bae8966261b93679 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 17:18:49 +0100 Subject: [PATCH 04/24] fix: enable CGO for Windows tests --- .github/workflows/build-docker-image.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index cdbca71..dca4ddb 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -53,6 +53,8 @@ jobs: run: go build - name: go-test + env: + CGO_ENABLED": "true" run: go test -race -v ./... build-image-linux: From 0039c44b02684af71a7eede1cc8d96d0462a6bc8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 17:20:28 +0100 Subject: [PATCH 05/24] fix: enable CGO for Windows tests --- .github/workflows/build-docker-image.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index dca4ddb..72d77be 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -54,7 +54,7 @@ jobs: - name: go-test env: - CGO_ENABLED": "true" + CGO_ENABLED": "1" run: go test -race -v ./... build-image-linux: From 9f768a4407ec3941ba88ed6be69a148f04589535 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 17:21:16 +0100 Subject: [PATCH 06/24] fix: typo in env var --- .github/workflows/build-docker-image.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index 72d77be..37266db 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -54,7 +54,7 @@ jobs: - name: go-test env: - CGO_ENABLED": "1" + CGO_ENABLED: "1" run: go test -race -v ./... build-image-linux: From fc39311383210d605a4557fa40b6f19d2fc202e0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 17:24:50 +0100 Subject: [PATCH 07/24] fix: install C compiler using choco --- .github/workflows/build-docker-image.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index 37266db..9025f30 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -52,6 +52,14 @@ jobs: GOOS: windows run: go build + # see https://go.dev/doc/articles/race_detector + # On Windows, the race detector runtime is sensitive to the version of the C compiler installed; as of Go 1.21, + # building a program with -race requires a C compiler that incorporates version 8 or later of the mingw-w64 runtime libraries. + # You can test your C compiler by invoking it with the arguments --print-file-name libsynchronization.a. + # A newer compliant C compiler will print a full path for this library, whereas older C compilers will just echo the argument. + - name: Install C compiler + run: choco install mingw -y + - name: go-test env: CGO_ENABLED: "1" From 911ce6f3132982758ad1ac3eeb03fbc4ae610aac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 17:30:18 +0100 Subject: [PATCH 08/24] chore: force installing mingw --- .github/workflows/build-docker-image.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index 9025f30..0803eb8 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -58,7 +58,7 @@ jobs: # You can test your C compiler by invoking it with the arguments --print-file-name libsynchronization.a. # A newer compliant C compiler will print a full path for this library, whereas older C compilers will just echo the argument. - name: Install C compiler - run: choco install mingw -y + run: choco install mingw -y -f - name: go-test env: From 25aa03009e27890a68954cd470261056d3ebdb80 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 17:34:43 +0100 Subject: [PATCH 09/24] chore: add to windows path --- .github/workflows/build-docker-image.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index 0803eb8..b99fecd 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -58,7 +58,9 @@ jobs: # You can test your C compiler by invoking it with the arguments --print-file-name libsynchronization.a. # A newer compliant C compiler will print a full path for this library, whereas older C compilers will just echo the argument. - name: Install C compiler - run: choco install mingw -y -f + run: | + choco install mingw -y -f + echo "C:\ProgramData\mingw64\mingw64\bin" >> $GITHUB_PATH - name: go-test env: From 2b6d471f78f9659025292e5a21e87a8d64d7dc6d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 17:36:25 +0100 Subject: [PATCH 10/24] fix: refresh env --- .github/workflows/build-docker-image.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index b99fecd..14e8e0c 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -65,7 +65,7 @@ jobs: - name: go-test env: CGO_ENABLED: "1" - run: go test -race -v ./... + run: refreshenv && go test -race -v ./... build-image-linux: runs-on: ubuntu-latest From f44ed9706bd911d62c249c2083650c89a80460ef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 17:38:14 +0100 Subject: [PATCH 11/24] fix: multiline --- .github/workflows/build-docker-image.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index 14e8e0c..cf90522 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -65,7 +65,9 @@ jobs: - name: go-test env: CGO_ENABLED: "1" - run: refreshenv && go test -race -v ./... + run: | + refreshenv + go test -race -v ./... build-image-linux: runs-on: ubuntu-latest From 98a830277e8977b0e34481e5c8b1c8d5308ec3a2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 17:43:49 +0100 Subject: [PATCH 12/24] chore: install mingw with an action --- .github/workflows/build-docker-image.yml | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index cf90522..50c9f00 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -57,17 +57,15 @@ jobs: # building a program with -race requires a C compiler that incorporates version 8 or later of the mingw-w64 runtime libraries. # You can test your C compiler by invoking it with the arguments --print-file-name libsynchronization.a. # A newer compliant C compiler will print a full path for this library, whereas older C compilers will just echo the argument. - - name: Install C compiler - run: | - choco install mingw -y -f - echo "C:\ProgramData\mingw64\mingw64\bin" >> $GITHUB_PATH + - name: Set up MinGW + uses: egor-tensin/setup-mingw@84c781b557efd538dec66bde06988d81cd3138cf // v2.2.0 + with: + platform: x64 - name: go-test env: CGO_ENABLED: "1" - run: | - refreshenv - go test -race -v ./... + run: go test -race -v ./... build-image-linux: runs-on: ubuntu-latest From 6dcaa18532005f149a9f83aa28523d896f94d36e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 17:44:34 +0100 Subject: [PATCH 13/24] fix: comment --- .github/workflows/build-docker-image.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index 50c9f00..d72770b 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -58,7 +58,7 @@ jobs: # You can test your C compiler by invoking it with the arguments --print-file-name libsynchronization.a. # A newer compliant C compiler will print a full path for this library, whereas older C compilers will just echo the argument. - name: Set up MinGW - uses: egor-tensin/setup-mingw@84c781b557efd538dec66bde06988d81cd3138cf // v2.2.0 + uses: egor-tensin/setup-mingw@84c781b557efd538dec66bde06988d81cd3138cf # v2.2.0 with: platform: x64 From 202e84e6d0914356fa41b49a0babc4c7a3225efb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 17:53:04 +0100 Subject: [PATCH 14/24] chore: install pwsh --- .github/workflows/build-docker-image.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index d72770b..50e1110 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -52,6 +52,9 @@ jobs: GOOS: windows run: go build + - name: Install pwsh + run: choco install pwsh --pre + # see https://go.dev/doc/articles/race_detector # On Windows, the race detector runtime is sensitive to the version of the C compiler installed; as of Go 1.21, # building a program with -race requires a C compiler that incorporates version 8 or later of the mingw-w64 runtime libraries. From 2c539f87db43af2592e2b446692d5b3bacc2a1c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 17:54:18 +0100 Subject: [PATCH 15/24] fix: accept install --- .github/workflows/build-docker-image.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index 50e1110..b710834 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -53,7 +53,7 @@ jobs: run: go build - name: Install pwsh - run: choco install pwsh --pre + run: choco install pwsh --pre -y # see https://go.dev/doc/articles/race_detector # On Windows, the race detector runtime is sensitive to the version of the C compiler installed; as of Go 1.21, From 00862019642d103ba455f633b08a2fc170e0d4e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 17:54:34 +0100 Subject: [PATCH 16/24] chore: force install --- .github/workflows/build-docker-image.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index b710834..0fbb870 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -53,7 +53,7 @@ jobs: run: go build - name: Install pwsh - run: choco install pwsh --pre -y + run: choco install pwsh --pre -y -f # see https://go.dev/doc/articles/race_detector # On Windows, the race detector runtime is sensitive to the version of the C compiler installed; as of Go 1.21, From 61ceb29a2c267c3c1a365026e49bc01b1c142b4c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 17:56:38 +0100 Subject: [PATCH 17/24] fix: do not use preview version --- .github/workflows/build-docker-image.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index 0fbb870..af3c2eb 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -53,7 +53,7 @@ jobs: run: go build - name: Install pwsh - run: choco install pwsh --pre -y -f + run: choco install pwsh -y -f # see https://go.dev/doc/articles/race_detector # On Windows, the race detector runtime is sensitive to the version of the C compiler installed; as of Go 1.21, From 7e5ef54cc34fb6c5f9a82f567510e87491919b82 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 17:58:01 +0100 Subject: [PATCH 18/24] fix: do not force preview --- .github/workflows/build-docker-image.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index af3c2eb..4911458 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -53,7 +53,7 @@ jobs: run: go build - name: Install pwsh - run: choco install pwsh -y -f + run: choco install pwsh -y # see https://go.dev/doc/articles/race_detector # On Windows, the race detector runtime is sensitive to the version of the C compiler installed; as of Go 1.21, From 19e2676a23576b6cc8f0d7cbbf6b40d427fc6af3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 17:59:15 +0100 Subject: [PATCH 19/24] fix: pin version --- .github/workflows/build-docker-image.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index 4911458..f84cfb6 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -53,7 +53,7 @@ jobs: run: go build - name: Install pwsh - run: choco install pwsh -y + run: choco install pwsh "7.4.6" -y -f # see https://go.dev/doc/articles/race_detector # On Windows, the race detector runtime is sensitive to the version of the C compiler installed; as of Go 1.21, From 7e5bfc343475e626632f05f357ed491ed9618be2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 18:01:23 +0100 Subject: [PATCH 20/24] fix: uninstall and reinstall --- .github/workflows/build-docker-image.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index f84cfb6..28a7150 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -53,7 +53,9 @@ jobs: run: go build - name: Install pwsh - run: choco install pwsh "7.4.6" -y -f + run: | + choco uninstall pwsh -y --remove-dependencies + choco install pwsh "7.4.6" -y # see https://go.dev/doc/articles/race_detector # On Windows, the race detector runtime is sensitive to the version of the C compiler installed; as of Go 1.21, From 1951024f0eefb9ae6f50ebe237586f909d54f131 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 18:10:04 +0100 Subject: [PATCH 21/24] chore: try plain install --- .github/workflows/build-docker-image.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index 28a7150..ca4b677 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -52,10 +52,9 @@ jobs: GOOS: windows run: go build - - name: Install pwsh + - name: Uninstall pwsh run: | choco uninstall pwsh -y --remove-dependencies - choco install pwsh "7.4.6" -y # see https://go.dev/doc/articles/race_detector # On Windows, the race detector runtime is sensitive to the version of the C compiler installed; as of Go 1.21, @@ -63,14 +62,15 @@ jobs: # You can test your C compiler by invoking it with the arguments --print-file-name libsynchronization.a. # A newer compliant C compiler will print a full path for this library, whereas older C compilers will just echo the argument. - name: Set up MinGW - uses: egor-tensin/setup-mingw@84c781b557efd538dec66bde06988d81cd3138cf # v2.2.0 - with: - platform: x64 + run: choco install mingw -y -f - name: go-test env: CGO_ENABLED: "1" - run: go test -race -v ./... + run: | + Import-Module "$env:ChocolateyInstall/helpers/chocolateyInstaller.psm1" + refreshenv + go test -race -v ./... build-image-linux: runs-on: ubuntu-latest From 205276590ff60762a75b9ae39a4948dc7eb8b757 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 18:17:14 +0100 Subject: [PATCH 22/24] fix: reorder --- .github/workflows/build-docker-image.yml | 30 +++++++++++------------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index ca4b677..8e74c32 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -35,6 +35,19 @@ jobs: test-windows: runs-on: [self-hosted, Windows, X64] steps: + # see https://go.dev/doc/articles/race_detector + # On Windows, the race detector runtime is sensitive to the version of the C compiler installed; as of Go 1.21, + # building a program with -race requires a C compiler that incorporates version 8 or later of the mingw-w64 runtime libraries. + # You can test your C compiler by invoking it with the arguments --print-file-name libsynchronization.a. + # A newer compliant C compiler will print a full path for this library, whereas older C compilers will just echo the argument. + - name: Set up MinGW + run: choco install mingw -y -f + + - name: Refresh env + run: | + Import-Module "$env:ChocolateyInstall/helpers/chocolateyInstaller.psm1" + refreshenv + - uses: actions/checkout@v4 - uses: actions/setup-go@v5 with: @@ -52,25 +65,10 @@ jobs: GOOS: windows run: go build - - name: Uninstall pwsh - run: | - choco uninstall pwsh -y --remove-dependencies - - # see https://go.dev/doc/articles/race_detector - # On Windows, the race detector runtime is sensitive to the version of the C compiler installed; as of Go 1.21, - # building a program with -race requires a C compiler that incorporates version 8 or later of the mingw-w64 runtime libraries. - # You can test your C compiler by invoking it with the arguments --print-file-name libsynchronization.a. - # A newer compliant C compiler will print a full path for this library, whereas older C compilers will just echo the argument. - - name: Set up MinGW - run: choco install mingw -y -f - - name: go-test env: CGO_ENABLED: "1" - run: | - Import-Module "$env:ChocolateyInstall/helpers/chocolateyInstaller.psm1" - refreshenv - go test -race -v ./... + run: go test -race -v ./... build-image-linux: runs-on: ubuntu-latest From 6fe68e303d1f8d6af6c98cf12c264cc6d824eaa6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Mon, 28 Oct 2024 18:18:53 +0100 Subject: [PATCH 23/24] chore: start small without race --- .github/workflows/build-docker-image.yml | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index 8e74c32..dccc3fb 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -35,19 +35,6 @@ jobs: test-windows: runs-on: [self-hosted, Windows, X64] steps: - # see https://go.dev/doc/articles/race_detector - # On Windows, the race detector runtime is sensitive to the version of the C compiler installed; as of Go 1.21, - # building a program with -race requires a C compiler that incorporates version 8 or later of the mingw-w64 runtime libraries. - # You can test your C compiler by invoking it with the arguments --print-file-name libsynchronization.a. - # A newer compliant C compiler will print a full path for this library, whereas older C compilers will just echo the argument. - - name: Set up MinGW - run: choco install mingw -y -f - - - name: Refresh env - run: | - Import-Module "$env:ChocolateyInstall/helpers/chocolateyInstaller.psm1" - refreshenv - - uses: actions/checkout@v4 - uses: actions/setup-go@v5 with: @@ -66,9 +53,7 @@ jobs: run: go build - name: go-test - env: - CGO_ENABLED: "1" - run: go test -race -v ./... + run: go test -v ./... build-image-linux: runs-on: ubuntu-latest From ce9f428185ab72afc698b521ebf8a6cb11292b7a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Wed, 20 Nov 2024 16:26:06 +0100 Subject: [PATCH 24/24] fix: close arg correctly --- testdata/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testdata/Dockerfile b/testdata/Dockerfile index 9ffcdda..f9d8a01 100644 --- a/testdata/Dockerfile +++ b/testdata/Dockerfile @@ -1,3 +1,3 @@ FROM scratch ARG arg1 -WORKDIR ${arg1}} +WORKDIR ${arg1}