From bab38d9c7b7ccd7e9e494ce36f98ed6609278f64 Mon Sep 17 00:00:00 2001 From: Michael Peyper Date: Tue, 12 Jan 2021 20:32:55 +1100 Subject: [PATCH] fix: stop appending container elements to document body --- src/dom/pure.ts | 3 --- src/native/pure.ts | 1 - src/server/pure.ts | 8 ++------ 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/dom/pure.ts b/src/dom/pure.ts index a3ca74fd..3958dd93 100644 --- a/src/dom/pure.ts +++ b/src/dom/pure.ts @@ -11,12 +11,10 @@ function createDomRenderer( { wrapper }: RendererOptions ) { const container = document.createElement('div') - const testHarness = createTestHarness(rendererProps, wrapper) return { render(props?: TProps) { - document.body.appendChild(container) act(() => { ReactDOM.render(testHarness(props), container) }) @@ -30,7 +28,6 @@ function createDomRenderer( act(() => { ReactDOM.unmountComponentAtNode(container) }) - document.body.removeChild(container) }, act } diff --git a/src/native/pure.ts b/src/native/pure.ts index 959024d6..2ce742aa 100644 --- a/src/native/pure.ts +++ b/src/native/pure.ts @@ -10,7 +10,6 @@ function createNativeRenderer( { wrapper }: RendererOptions ) { let container: ReactTestRenderer - const testHarness = createTestHarness(rendererProps, wrapper) return { diff --git a/src/server/pure.ts b/src/server/pure.ts index b58a44a1..b8a40055 100644 --- a/src/server/pure.ts +++ b/src/server/pure.ts @@ -11,12 +11,10 @@ function createServerRenderer( rendererProps: RendererProps, { wrapper }: RendererOptions ) { - const container = document.createElement('div') - - const testHarness = createTestHarness(rendererProps, wrapper, false) - let renderProps: TProps | undefined let hydrated = false + const container = document.createElement('div') + const testHarness = createTestHarness(rendererProps, wrapper, false) return { render(props?: TProps) { @@ -30,7 +28,6 @@ function createServerRenderer( if (hydrated) { throw new Error('The component can only be hydrated once') } else { - document.body.appendChild(container) act(() => { ReactDOM.hydrate(testHarness(renderProps), container) }) @@ -49,7 +46,6 @@ function createServerRenderer( if (hydrated) { act(() => { ReactDOM.unmountComponentAtNode(container) - document.body.removeChild(container) }) } },