Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage uploads for non-amd64 architectures #598

Closed
codefromthecrypt opened this issue May 28, 2022 · 3 comments
Closed

Add code coverage uploads for non-amd64 architectures #598

codefromthecrypt opened this issue May 28, 2022 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@codefromthecrypt
Copy link
Contributor

Is your feature request related to a problem? Please describe.
https://app.codecov.io/gh/tetratelabs/wazero doesn't include all main sources, rather just amd64

We should have all sources. There are notably more for arm64, but also a few for neither (risc-v)

Describe the solution you'd like
I'd like codecov to present a merged view of all sources, which are materialized by emulated arm64 and risc-v also uploading reports.

Describe alternatives you've considered
not doing anything

Additional context
#596 (comment)

@codefromthecrypt codefromthecrypt added enhancement New feature or request help wanted Extra attention is needed labels May 28, 2022
@codefromthecrypt
Copy link
Contributor Author

note: the GitHub action for codecov doesn't yet support non-amd64 codecov/uploader#523

@codefromthecrypt
Copy link
Contributor Author

TL;DR; let's use the normal bash script until non-amd64 works on the action, or they drop the bash script

if they really delete the bash script before fixing non-amd64 a complicated workaround would be to have a fan-in upload stage. basically run all the coverage in a matrix and upload artifacts with the coverage.txt. block on that, download all the coverage.txt into a different directory or path and then use codecov/codecov-action@v2 action to send them at the same time.

The ideal way out is to wait for non-amd64 to work and use the bash script meanwhile.

@philippgille
Copy link
Contributor

The referenced PR for the codecov uploader is now closed since 2 days and they link to arch-specific uploader binaries, so we could give it a try.

One question:

Currently the coverage only runs as part of the test_amd64 job here.

Is your plan to

  1. Rename that to be arch independent and add other architectures to the matrix?
  2. Or add arm64 and riscv64 jobs next to it?
  3. Or add coverage tracking to the test_scratch job, which already has all three architectures in [its matrix](https://github.com/tetratelabs/wazero/blob/9138b6f722ca855
    c8f498df6749f302a8a4e9ffa/.github/workflows/commit.yaml#L107-L114)?

@mathetake mathetake closed this as not planned Won't fix, can't repro, duplicate, stale Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants