Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-needle x-stitch-number #22

Open
ixchow opened this issue Feb 22, 2021 · 2 comments
Open

Per-needle x-stitch-number #22

ixchow opened this issue Feb 22, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@ixchow
Copy link
Member

ixchow commented Feb 22, 2021

Currently, the backend starts a new pass for each new stitch number; but the kniterate does not require this.

Proposed fix:
add a "stitch-numbers" array to each pass along with the slots array and store stitch numbers into it, only breaking passes when conflicting stitch numbers for a given slot are found.

Alternate fix: add a "stitch-number" field to each slot in the slots array.

@ixchow ixchow added the enhancement New feature or request label Feb 22, 2021
@ixchow
Copy link
Member Author

ixchow commented Mar 2, 2021

Some more questions that came up in implementation:
What stitch number should needles which don't have stitches on them use?
Possible resolutions:

  • the number from the closest same-bed needle that has a stitch assigned
  • a linear interpolation between the two adjacent stitch numbers (only makes sense if stitch numbers map directly to lengths)
  • the number from the next (in pass direction) needle that has a stitch assigned (idea: give stitch cam as much time as possible to switch settings; only makes sense if machine firmware isn't already doing some sort of look-ahead)
  • a 'default' or 'empty' value. (is that 0?)

What stitch number should be used on a bed with no stitches on it?
Possible answers:

  • The stitch cam values from the other bed (directly copied)
  • The most-used value from the other bed
  • A 'default' or 'empty' value. (0?)

For a first pass of implementation, I am leaning toward choosing "the next value in pass direction" and "default/empty (0)".

@ixchow
Copy link
Member Author

ixchow commented Mar 3, 2021

Preliminary support added in 0d269b2 ; implementation stores stitch values in every slot and uses within-pass lookahead to fill missing stitch values. In case of passes with no needles set to a particular stitch cam value, 0 is used for the whole bed.

It would likely be useful to use further lookahead to resolve the stitch value ambiguity.

Note, I also added x-xfer-stitch-number to set stitch numbers independently for xfer operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant