Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

struct member highlighted in red #72

Open
mattgallivan opened this issue Jun 8, 2021 · 1 comment
Open

struct member highlighted in red #72

mattgallivan opened this issue Jun 8, 2021 · 1 comment

Comments

@mattgallivan
Copy link

See here.

The member significand is highlighted in red, while all other members are white. I have searched for matching keywords that might color it this way, but to no avail.

@Alcaro
Copy link

Alcaro commented May 6, 2022

It's from this file, along with 3257 other deprecated names.

Most of the deprecations are properly namespaced and/or otherwise harmless (or even helpful) to warn about, but some of the 3258 are quite suspicious. In addition to significand, a quick glance reveals

{ // Some of them only turn red if inside a set of braces.
GetCurrentThread, GetCurrentProcess // Windows functions
daemon, syscall // glibc functions
compound, finite, gamma, pi, relation // Perfectly normal words
Button, Debugger, DebugAssert, Delay, Enqueue, Microseconds // Perfectly plausible class or function names
}

Full list, extracted from Platform.md

Warning about deprecated mac functions makes sense for a mac-only text editor like TextMate, but it makes significantly less sense for a syntax highlighter used across the entire GitHub.

And even for a mac-only text editor, some of the above are more likely to be project-local struct members or local variables than to be references to deprecated functionality.

My personal preference would be remove the deprecation list, turning those 3258 into unrecognized identifiers, and leave deprecation warnings to the compiler. But there are many possible answers, and I'm not a mac user, so I can't determine which would be the best for TextMate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants