Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting is broken for handlebars comments #123

Open
alexr00 opened this issue Dec 7, 2022 · 0 comments
Open

Syntax highlighting is broken for handlebars comments #123

alexr00 opened this issue Dec 7, 2022 · 0 comments

Comments

@alexr00
Copy link

alexr00 commented Dec 7, 2022

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.73.1
  • OS Version: Darwin x64 21.6.0

Steps to Reproduce:

  1. Create a file called helloworld.hbs and paste this there: {{!-- outer comment {{!-- inner comment --}} {{hello --}}
    Below is what you see on the screen.
    index view — project_panther_fe 2022-12-06 16-34-05

  2. Visit https://handlebarsjs.com/playground.html and in the template section, also paste the above string. Then open your browser console, you will notice compile errors.
    Below is what you see on the screen.
    Handlebars 2022-12-06 16-31-51

According to the the handlebars parser (also as you can see in the handlebars playground as well), the first "--}}" encountered terminates the comment. But VS Code tricks the developer into thinking that the comment is only terminated after the last "--}}". This will lead to errors and a poor experience

Originally opened by @tonyobanon in microsoft/vscode#168179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant