Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot take SSD Marine if already spawned with same name #17112

Open
Breadeagle opened this issue Feb 13, 2025 · 0 comments
Open

Cannot take SSD Marine if already spawned with same name #17112

Breadeagle opened this issue Feb 13, 2025 · 0 comments
Labels
Bug Incorrect functionality.

Comments

@Breadeagle
Copy link

Breadeagle commented Feb 13, 2025

Description

If you spawned and died or ghosted on marine, taking an SSD marine with the same name preference will fail, due to same name. It attempts to take your preferred name, which has already spawned, and then gives you the log saying you can't.

Spawning as SSD used to use random name, so this is almost certainly caused by the PR that made it take your preference. You can solve this by switching preference slot to another name, but this is somewhat unintuitive unless you were there for the change.

Probably make it possible to use same name, or revert it back to random? OR random name if you've already spawned with the name?

Test Merges

Round ID: 35015
BYOND Version: 515.1647
Server revision compiled on: 2025-02-12T23:17:53+00:00
Master commit: 5246d64c098a9ebb736ff5f556eb45b94edfd7b9
The following pull requests are currently test merged:
#17031: 'GITHUB API ERROR: BAD CREDENTIALS' by GITHUB API ERROR: BAD CREDENTIALS at commit b973b57170
#17059: 'GITHUB API ERROR: BAD CREDENTIALS' by GITHUB API ERROR: BAD CREDENTIALS at commit e7e85df44d
#17054: 'GITHUB API ERROR: BAD CREDENTIALS' by GITHUB API ERROR: BAD CREDENTIALS at commit 456cfdb4f1
#17066: 'GITHUB API ERROR: BAD CREDENTIALS' by GITHUB API ERROR: BAD CREDENTIALS at commit 1c9bb93d5d
#17049: 'GITHUB API ERROR: BAD CREDENTIALS' by GITHUB API ERROR: BAD CREDENTIALS at commit 3573fd62b1

Local commit: 3bcfc8eced98c441c014da765b1a1bd7a9ebf9c7
Server tools version: 6.12.3

Reproduction Steps

Steps:

  1. Spawn as marine
  2. Die/ghost
  3. Attempt to take SSD marine
  4. Do not change preferences
  5. Find yourself unable to take SSD due to name

Screenshots

No response

@Breadeagle Breadeagle added the Bug Incorrect functionality. label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect functionality.
Projects
None yet
Development

No branches or pull requests

1 participant