-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rm-84612] Added th2 transport support #10
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, update the Gradle version in the Dockerfile
src/main/kotlin/com/exactpro/th2/codec/hand/CodecHandFactory.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/exactpro/th2/codec/hand/CodecHandFactory.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/exactpro/th2/codec/hand/processor/HandProcessor.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/exactpro/th2/codec/hand/processor/ProtobufHandProcessor.kt
Outdated
Show resolved
Hide resolved
|
||
setMessage( | ||
Message.newBuilder().apply { | ||
setMetadata(msgMetaData) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to set the protocol here
class Context(message: RawMessage) { | ||
val id: MessageId = message.id | ||
val metadata: Map<String, String> = message.metadata | ||
val protocol: String = message.protocol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that the protocol will be set in the raw message?
Co-authored-by: Oleg Smirnov <[email protected]>
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
.github/workflows/build-sanpshot.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This builds a docker image. I don't think we can call it a 'snapshot'... Should we rename the workflow file?
No description provided.