Parent event id for echo #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cordwelt
suggested changes
Jul 16, 2021
src/main/kotlin/com/exactpro/th2/ws/client/api/impl/WebSocketClient.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/exactpro/th2/ws/client/api/impl/WebSocketClient.kt
Outdated
Show resolved
Hide resolved
cordwelt
reviewed
Aug 2, 2021
# Conflicts: # README.md # gradle.properties # src/main/kotlin/com/exactpro/th2/ws/client/api/impl/WebSocketClient.kt
# Conflicts: # README.md # gradle.properties
cordwelt
suggested changes
Mar 22, 2022
| @@ -152,7 +154,7 @@ fun run( | |||
| require(messagesCount == 1) { "Message group contains more than 1 message" } | |||
| val message = messagesList[0] | |||
| require(message.hasRawMessage()) { "Message in the group is not a raw message" } | |||
| settings.frameType.send(client, message.rawMessage.body.toByteArray()) | |||
| settings.frameType.send(client, message.rawMessage.body.toByteArray(), message.rawMessage.parentEventId) | |||
There was a problem hiding this comment.
message.rawMessage.parentEventId
It'll always be non-null. We should check its presence through hasParentEventId method instead and pass null if it returns false
| @@ -121,7 +122,7 @@ class WebSocketClient( | |||
| if (last) { | |||
| val message = if (binaryFrames.isEmpty()) frame else binaryFrames.reduce(ByteArray::plus) | |||
| handler.onBinary(this, message) | |||
| onMessage(message, false, FIRST) | |||
| onMessage(message, true, FIRST, null) | |||
There was a problem hiding this comment.
Suggested change
| onMessage(message, true, FIRST, null) | |
| onMessage(message, false, FIRST, null) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.