Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting endpoint for Google Cloud Storage (GCS) in Thanos #7862

Open
antcs opened this issue Oct 28, 2024 · 1 comment
Open

Support setting endpoint for Google Cloud Storage (GCS) in Thanos #7862

antcs opened this issue Oct 28, 2024 · 1 comment
Labels
difficulty: easy help wanted package: objstore Mark PRs and issues needs to be migrated to thanos-io/objstore

Comments

@antcs
Copy link

antcs commented Oct 28, 2024

Is your proposal related to a problem?

We need to override the Google API endpoint used by Thanos for GCS storage to ensure usage of GCP regional endpoints.

Describe the solution you'd like

Proposal for a solution:

  1. Add an option which can be used to configure the endpoint for the GCP storage client
  2. Enhance the GCS client to set it using the option.WithEndpoint(...): https://github.com/grafana/thanos/blob/main/scripts/cfggen/main.go
  3. It seems thanos-io/objstore is also used to support common actions with GCS. The functionality should also be added here: https://github.com/thanos-io/objstore/blob/main/providers/gcs/gcs.go

Describe alternatives you've considered

/

Additional context

/

@dosubot dosubot bot added the package: objstore Mark PRs and issues needs to be migrated to thanos-io/objstore label Oct 28, 2024
@yeya24
Copy link
Contributor

yeya24 commented Nov 11, 2024

I think this is a valid proposal. Help wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy help wanted package: objstore Mark PRs and issues needs to be migrated to thanos-io/objstore
Projects
None yet
Development

No branches or pull requests

2 participants