beautiful-react-redux/check should be configurable

[pavelvlasov]

The initial suggestions will be to allow throw an error instead of console.error.

It might look like this:

import check from 'beautiful-react-redux/check';

check({throwError: true});

Any other thoughts @theKashey?

[theKashey]

The only question - who we are going to confugure - beautiful-react-redux, which could wrap shouldBePure with itown logic, or memoize-state, which generating errors.
There is also a problem with verbosity in memoize-state after theKashey/memoize-state#5

There is also one more point to configure - "the safe" memoization mode (https://github.com/theKashey/memoize-state/blob/master/src/index.js#L240) used here. It will also check that 2 "same" mapStateToProps calls will use the same keys to generate result, which may fail if you have deep reselect cascade.

Ie, look like configuration should be just passed down to memoizeState, and there is 3 points to set

• log or throw in purityCheck
• use safe mode or not.
• detect spreads or not.

2 last are enabled by default, but might be better disabled.

[theKashey]

import setConfig from 'beautiful-react-redux/check'
setConfig({ onNotPure: (...errormsg) => { throw new Error(errormsg.join(''));

Not documented feature yet, not sure about naming. But you could try it.

[pavelvlasov]

Looks good!
I would rename it to onError and pass error object in, e.g.

setConfig({onError: (err) => throw err});

I don't think you can do much with whatever array is passed in.

But huge thanks anyway 👍

[theKashey]

And now I have understand how to make it better....