Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exdeorum.removeDefaultSieveRecipes(event) does not remove the compressed recipes #102

Open
arketec opened this issue Jul 11, 2024 · 4 comments
Labels
wontfix This will not be worked on

Comments

@arketec
Copy link

arketec commented Jul 11, 2024

version: 1.20.1
mod version: 1.38

in kubejs:

server_scripts:
ServerEvents.recipes((event) => {
exdeorum.removeDefaultSieveRecipes(event)
event.custom({
type: "exdeorum:sieve",
ingredient: {
item: "exdeorum:crushed_end_stone",
},
mesh: "exdeorum:diamond_mesh",
result: "minecraft:ender_pearl",
result_amount: {
type: "minecraft:binomial",
n: 1,
p: 0.4,
},
});
})

expected:
all sieve drops removed except crushed_end_stone with ender_pearl

actual:
all sieve drops removed from normal sieve except crushed end endstone with ender pearls (correct), but all compressed block recipes still exists including all the compressed_crushed_end_stone recipes (unexpected)

@thedarkcolour
Copy link
Owner

This is intended behavior. I made the removeAllSieveRecipes when I didn't know anything about KubeJS. The correct way to remove compressed sieve recipes is by using the following:

remove({
  type: "exdeorum:compressed_sieve"
});

@thedarkcolour
Copy link
Owner

I'll close this issue when I update the docs with the correct methods.

@arketec
Copy link
Author

arketec commented Jul 12, 2024

ok thanks. to clarify, if i then add new drops via event.custom or with a datapack, do those automaitcally get added to the compressed sieve? or must I register drops for the compressed sieve separately? also, how is this affected by
remove({ type: "exdeorum:compressed_sieve" });
?

@thedarkcolour
Copy link
Owner

They must be registered separately, and you need to multiply the result count by seven (for the binomial number provider, just multiply n). I recommend making a helper function that does both recipes at once.

@thedarkcolour thedarkcolour added the wontfix This will not be worked on label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants