Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hammer plugin #37

Closed
ezr-ondrej opened this issue Oct 7, 2020 · 8 comments
Closed

Hammer plugin #37

ezr-ondrej opened this issue Oct 7, 2020 · 8 comments

Comments

@ezr-ondrej
Copy link
Member

https://github.com/amirfefer/hammer-cli-foreman-puppet

@nadjaheitmann
Copy link
Collaborator

nadjaheitmann commented Apr 22, 2021

I can work on the hammer plugin as well.

https://github.com/amirfefer/hammer-cli-foreman-puppet

Is this the current status?

@ezr-ondrej
Copy link
Member Author

It would be awesome, if you could team up with @amirfefer on this.

Current status

There is a draft @ekohl started to clean up the core code prior it's removal, that would be great to finalize before moving to the plugin. Ewoud is saying he struggles to find time to finish it, so if you'd like to take that, that would be appreciated:
theforeman/smart-proxy#771

@amirfefer recently resumed work on the plugin, so probably first asking him to push the recent changes prior to sending PRs, but his repo is indeed the primary develop repo as of now, before we move it under theforeman org.

@nadjaheitmann
Copy link
Collaborator

Thanks for the update. I will get in contact with @ekohl and @amirfefer about the topics.

@ekohl
Copy link
Member

ekohl commented Apr 26, 2021

@ezr-ondrej my PR is not really about hammer but really about the Smart Proxy modules.

@ezr-ondrej
Copy link
Member Author

My bad, I've messed things up. Weren't there something similar for hammer, or am I just imagining stuff?

@nadjaheitmann
Copy link
Collaborator

Let me know if there is another PR that needs fixing before the Hammer plugin can move on. Right now, I am waiting for @amirfefer to provide some up-to-date information.

@nadjaheitmann
Copy link
Collaborator

Same as for #150, shall we close it? Hammer puppet plugin is up and working :) we can open new issues if necessary.

@ezr-ondrej
Copy link
Member Author

Closing as it is in Done column but not closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants