-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starfall screen will render twice per frame if map has water #1773
Comments
A preferred solution would allow users to exit any render hook early, and not just screens. Also, it would be great if it was optional, in the case where we do want to allow rendering in reflections, or maybe even only in reflections for some interesting possibilities. |
was thinking maybe moving the screen rendering into postdrawopaquerenderables hook or something. this would also allow the screen to draw despite the model being invisible |
It wouldn't have correct draw ordering with respect to other translucent things though |
That on its own shouldn't work, because DrawOpaqueRenderables also gets called for water reflections |
Suggestion: If it's possible to find out "where" in the render hook order a given hook is when it's called, there could be a function that returns a boolean for if a hook is being called for DrawWaterReflections or not. If there isn't a way to do this directly, maybe it can be done by observing the order render hooks are called in when near water vs when not. |
Yes, I know it's for the water effect, but this is problematic for user code that relies on timing or performance.
The text was updated successfully, but these errors were encountered: