Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing default settings for the package #536

Open
3 tasks
nyamsprod opened this issue Sep 13, 2024 · 0 comments
Open
3 tasks

Changing default settings for the package #536

nyamsprod opened this issue Sep 13, 2024 · 0 comments

Comments

@nyamsprod
Copy link
Member

nyamsprod commented Sep 13, 2024

Feature Request

Q A
New Feature no
BC Break yes
version 10.0

Proposal

We must revisit all default options of the package to match expected default for modern CSV handling. Changing any default from version 9 is automatically a BC break to be clearly documented.

  • escape character must default to the empty string; previously was \.
  • Reader::createFromPath must default to r open mode
  • Writer::createFromPath must default to r+ open mode

Changing the open mode will be done by removing the createFromPath method from the AbstractCSV class to implement it directly into the Reader and the Writer classes.

Should those classes be made final ❓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant