You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The text was updated successfully, but these errors were encountered:
uuf6429
changed the title
Root exception class not compatible with PHP7+
Root exception class (and possibly, its children) not compatible with PHP7+
Sep 7, 2022
route/src/Http/Exception.php
Line 30 in b2d82a8
This breaks on PHP 7+ when a non-\Exception throwable is thrown (e.g. TypeError; see also the type hierarchy).
For best compatibility, the type declaration should be removed. If needs be,
?\Exception
/?\Throwable
could be defined via PHPDoc.Since it's removing a restriction, I don't think this should be considered as a BC break.
On a side note, not sure why it needs to keep a copy of the message:
route/src/Http/Exception.php
Line 20 in b2d82a8
and
route/src/Http/Exception.php
Line 35 in b2d82a8
An effective stopgap solution for my use-case:
The text was updated successfully, but these errors were encountered: