Defense channels and rolemapping #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Notes This adds an additional feature to the new audit channel flow. Once an `ext-name-audit` channel is setup, now you can make an `int-name-audit` channel, which will perform these steps: 1. Setup a new role `Defense Internal: Name` 2. Generate an invite for the `int-name-audit` channel 3. Check if a matching `ext-name-audit` channel exists, if so assign `ViewChannel` permission to `Defense Internal: name` role.
zuuring
changed the title
This is still a work in progress just testing out the ability of assigning a role to an invite based of the uses it has.
Rewrite some of the checks and counts in-order to correctly match the role. The previous method was breaking on different format channels such as `ext-thesis-test-audit`
Moves `listInvites` into it's own function for easier calls
Refactor the `guildMemberAdd` event to resolve lint expression errors and make sure channel name is found correctly based on ext, int patterns
Resolves the issue that would fail to assign internal roles to external channel if the channel name had the format `ext-client-name-audit` vs `ext-clientname-audit`
This fixes the bug happening on invites not counting correctly if they were being used more than 2 times on certain edge cases.
zuuring
commented
Mar 19, 2024
zuuring
commented
Mar 19, 2024
This is still WIP but adds the `defense-audit` command with the parameter `client-name` to automatically build `int-clientname-audit` and `ext-clientname-audit` channels with two roles `Defense Internal: ClientName` and `Defense External: ClientName`. Can only be run from the `defense` category
This commit makes it so the `defense-audit` command can only be run within the `defense` parent category of channels and will send a reply if it isn't working as it should. Also adds an `interaction.editReply` inorder to avoid any timeout issues happening
Removes the debug loggers from the scripts, not needed anymore!
|
Question here: can we kill the embeds in the intro message? |
Shadowfiend
requested changes
Apr 11, 2024
This commit adds a number of changes to the audit channel flow. mainly: - Update permissions if channel already exists - Check if role already exists, if so skip - Changed logic so that if audit channels already exist, we output a different message to interaction - Remove embeds by wrapping invite URL in quotes. - Change verbiage around messages - Separates InternalChannel and externalChannel - Changed invite code permission match
|
@Shadowfiend Just pushed an update to this with fixes to the review comments as following:
Now one thing that came up, turns out Discord channel categories have a limit of max (50) channels per category. Should we maybe setup an "Audit" category or even (not ideal) a channel category on a per client basis? |
Lawd. I think we can hold for now, as I don't think we're going to have 20 audits going in parallel, and older audits will get archived. Making them their own category is a good idea though and we can discuss with Defense once we've got the basics working here. |
This commit switches over from discordjs `Collection` in favour of storing invites as an object.
Shadowfiend
requested changes
Apr 19, 2024
This commit does some refactoring based off review feedback (thank you!) as well as making sure the invite uses / expiry date is listed properly.
|
@Shadowfiend Just pushed an update on this with the fixes based on your review! I also added a way to show expiry date using Discord's built in time rendering. That way we get a nice hover event when going over the expiry time. |
Shadowfiend
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This adds a new discord command
defense-auditwhich has one parameterclient-namewhich will then perform the following steps:int-clientname-auditandext-clientname-auditDefense Internal: clientnameandDefense Extenal: clientnameViewChannelaccess to both channels forDefense Internal: *and onlyext-*-auditchannel access toDefense ExtenalScreenshot
Automatic role assignment
Also included in this PR is automatic role assignment based of the invite code used. Due to lack of IDs associated to
GuildMemberAddevents when a new user joins discord, the only way to tie a discord user to an invite link is to count invite code uses within the guild and compare it once a new member has joined the discord. For this to work, we check the invites and match role assignment to channel.name the invite link was generated from.To-do
defense-auditcommandint-client-name-auditchannels not finding correct role forext-client-name-auditchannels