Custom auto-tagging #303
Merged
Custom auto-tagging #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Notes This adds the ability to modify the auto-tagging function of Valkyrie based off of a defined list of `PRIVATE_CHANNELS`. It also will match the tagging to the role specified, in order to have custom roles tagged for specific threads started in a channel. ### Handling IDs Alternatively, we can also modify this to work directly with channel / role IDs rather than names, but in testing it seems to be working as it should.
Shadowfiend
reviewed
Apr 3, 2024
Shadowfiend
reviewed
Apr 3, 2024
This commit renames main channel const to `CUSTOM_CHANNEL_ROLE` and makes sure `matchingChannel` check runs before the rest.
|
@Shadowfiend Did some changing around based on your feedback so this should be good now! |
Shadowfiend
reviewed
Apr 11, 2024
| @@ -35,6 +38,21 @@ async function autoJoinThread( | |||
|
|
|||
| const placeholder = await thread.send("<placeholder>") | |||
|
|
|||
| // Use this to assign a specific role based on the mapping in CUSTOM_CHANNEL_ROLE, in order to map specific roles/channels | |||
| const matchingChannel = CUSTOM_CHANNEL_ROLE.find( | |||
There was a problem hiding this comment.
Suggested change
| const matchingChannel = CUSTOM_CHANNEL_ROLE.find( | |
| const matchingChannelOverride = CUSTOM_CHANNEL_ROLE.find( |
Shadowfiend
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This adds the ability to modify the auto-tagging function of Valkyrie based off of a defined list of
PRIVATE_CHANNELS. It also will match the tagging to the role specified, in order to have custom roles tagged for specific threads started in a channel.Handling IDs
Alternatively, we can also modify this to work directly with channel / role IDs rather than names, but in testing it seems to be working as it should.