Add multi-tagging #316
Add multi-tagging #316
Conversation
### Notes This adds the ability to tag several groups into one channel with the auto-tagging function.
| @@ -26,7 +26,7 @@ import { | |||
| const CUSTOM_CHANNEL_ROLE: Record<string, string> = { | |||
| // hiring: "PeopleOps", | |||
| "biz-dev-investor": "BD", | |||
| "press-relations": "M Group", | |||
| "press-relations": "M Group, Marketing", | |||
There was a problem hiding this comment.
Might as well make this an array here instead of having to split later.
| await placeholder.edit(channelMatchingRole.toString()) | ||
| const roleNames = CUSTOM_CHANNEL_ROLE[containingChannel.name] | ||
| ?.split(",") | ||
| .map((role) => role.trim()) |
There was a problem hiding this comment.
This isn't a user input so no need to trim. If we allow users to set this manually later, we should trim when they give us a role name, rather than having to do it every time we check for matching channels.
|
@Shadowfiend Thanks for the comments! Just refactored this and added typechecks as well. |
| // hiring: "PeopleOps", | ||
| "biz-dev-investor": "BD", | ||
| "press-relations": "M Group", | ||
| interface ChannelRoleMapping { |
There was a problem hiding this comment.
Not blocking but let's fix in a follow-up: as a general rule, use type * = { instead of interface * {.
| interface ChannelRoleMapping { | |
| type ChannelRoleMapping = { |
| (mapping) => mapping.channelName === containingChannel.name, | ||
| ) | ||
|
|
||
| if (channelMapping && channelMapping.roles.length > 0) { |
There was a problem hiding this comment.
We can really replace this outer if with:
const channelRoles = channelMapping?.roles ?? []
const rolesToTag = channelRoles.map...
| const rolesToTag = roleNames | ||
| .map((roleName) => | ||
| server.roles.cache.find( | ||
| (role) => role.name.toLowerCase() === roleName.toLowerCase(), | ||
| ), | ||
| ) | ||
| .filter((role): role is Role => role !== undefined) |
There was a problem hiding this comment.
Slightly cleaner version we didn't use before:
| const rolesToTag = roleNames | |
| .map((roleName) => | |
| server.roles.cache.find( | |
| (role) => role.name.toLowerCase() === roleName.toLowerCase(), | |
| ), | |
| ) | |
| .filter((role): role is Role => role !== undefined) | |
| // make sure roleNames is all lowercased beforehand. | |
| const rolesToTag = roleNames | |
| .filter((role): role is Role => | |
| roleNames.includes(role.name.toLowerCase())) |
| @@ -76,9 +87,7 @@ async function autoJoinThread( | |||
| const matchingRole = server.roles.cache.find( | |||
| (role) => | |||
| roleMatchPrefixes?.some( | |||
| (channelPrefixRole) => | |||
| role.name.toLowerCase() === | |||
| channelPrefixRole /* already lowercased above */, | |||
There was a problem hiding this comment.
Feels like this is an important note to keep 😬
Notes
This adds the ability to tag several groups into one channel with the auto-tagging function.