Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate bug: Heimdall replies to user by id instead of name #86

Closed
3 tasks done
kb0rg opened this issue Jul 17, 2019 · 2 comments
Closed
3 tasks done

Investigate bug: Heimdall replies to user by id instead of name #86

kb0rg opened this issue Jul 17, 2019 · 2 comments
Assignees

Comments

@kb0rg
Copy link
Contributor

kb0rg commented Jul 17, 2019

After calling the \zoom command, a new user was referred to by id instead of username.

We suspect this bug is related to an issue filed in the flowdock adapter repo:

res.reply doesn't use user's display name if they joined flow after Hubot started

However that issue suggests that restarting Hubot will fix the issue. In the case we saw in our org, the timeline doesn't line up:

  • new user joined the flow a couple days ago
  • Heimdall deploys a new build this morning
  • the new user calls \zoom a few hours after Heimdall's new build is released

We should investigate:

  • Try restarting Heimdall
  • If restarting fixes the problem, document it for future reference see test
  • If restarting does not fix the problem, investigate more, and try to create another solution

Links:

@kb0rg kb0rg self-assigned this Jul 17, 2019
@kb0rg kb0rg mentioned this issue Jul 20, 2019
7 tasks
@Shadowfiend
Copy link
Contributor

Feels like we can wrap this guy up?

@kb0rg
Copy link
Contributor Author

kb0rg commented Jul 26, 2019

Yeah, I think so, if you're happy with the current workaround.
(I consider the \reconnect command a workaround more than a fix, per se)

Then again, this fulfills the stated mission to investigate the bug, so yeah, I'll close it.. :)

@kb0rg kb0rg closed this as completed Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants