Notifiarr notifications support #369
phutur1st
started this conversation in
Feature Requests
Replies: 1 comment
-
If there is interest in it, native is also an option (assuming the codebase supports it which i guess it does somehow for passthrough to work) |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello!
I've added support locally for notifications via Notifiarr's passthrough integration. I'm considering a pull request once tweaked for public consumption, however I want to make sure the contribution delivers the best value to this project.
Included in the Notifiarr handler is options to drop fields from the json payload if they are null, -1, or "Missing Value."
Additionally, it includes the option to choose which combination of time values to include in the payload (ie utc_time, local_time, local_time_adjusted.) I felt this approach, which dynamically removes fields not used for a given event was more practical than providing a user entered array/map of fields to include per logtype. It also iterates the logtype map and provides human readable names for the logtype field, replacing 2000 with 2000: FTP Login Attempt for a more descriptive notification.
Before proceeding too much further, I wanted to gauge interest in moving the method for configuring/dropping null values and setting desired time fields out of the Notifiarr handler class, and into logger.py et al. This would theoretically make it easier for other handlers such as Slack or a new MS Teams method to utilize the field dropper method.
Of course if this goes stale, or feedback is meh, I'll just move forward with an all in Notifiarr handler or run my local fork. I thought there was some value to ask. Thanks for your thoughts!
Note: I've not linked the Notifiarr project directly, as I'm directly not affiliated.
Example notifs:
(w/ null fields truncated)
Beta Was this translation helpful? Give feedback.
All reactions