Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace 'createListing' - "The transaction failed onchain" intermittent issue #733

Open
Kuro182 opened this issue Oct 18, 2024 · 3 comments
Labels

Comments

@Kuro182
Copy link

Kuro182 commented Oct 18, 2024

We've updated engine version from v0.9.1 to the latest (v2.0.29) and facing intermittent issue while creating listings on MarketplaceV3.

Issue happens if we mint several tokens for ERC1155 and after calling createListing for these tokens - some transactions are failing with
Error
The transaction failed onchain. See: https://portal.thirdweb.com/engine/troubleshooting

If we create listing just for one token of ERC1155 (TokenId = 0) - all works fine.

Reverted back to v0.9.1 - listings work fine, so it looks like a bug in newest versions.

Also if we trying to call createListing not in engine but in Marketplace Explorer - no issues (First pic)
image
image

@arcoraven
Copy link
Contributor

The "The transaction failed onchain." error means the transaction was mined but received an "execution reverted" error from the contract. You can view the transaction hash to see if the contract returned any specific error to help you troubleshoot. You can also try adding the ?simulateTx=true queryparam to the createListing call to see if it returns any simulation error.

The MarketplaceV3 code is untouched between the versions you specified. Since the issue is inconsistent, one hunch may be that since Engine v2 processes transactions much faster than v1, there is a timing issue somewhere.

@Kuro182
Copy link
Author

Kuro182 commented Oct 21, 2024

We've tried to use ?simulateTx=true - got 200 response, and transaction is also Mined, but inside it there is an error.

Also checked transaction hash - there is no useful information in it (here is an example of failed transaction - https://amoy.polygonscan.com/tx/0xe25b9ecc2ed7ef98e5a44fe6c4aca7d4f285fd074c2ca03365aa0852637140b2) and all data is the same as in Successful transaction.

About timing - we've tried to call createListing transactions with 5-10 minutes break between each call and it also fails.

So the only one thing we've noted as i've already said - createListing works fine with v0.9.1 but fails intermittently in newest versions

@d4mr
Copy link
Member

d4mr commented Oct 22, 2024

Hi @Kuro182, we have determined that the revert is caused due to the transaction going out of gas. While we fix this issue, you can circumvent it by specifying a gas override as a part of the txOverrides in the request body (reference). For the transaction you reference here, a value of 280,000 should be safe.

@github-actions github-actions bot added the Stale label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants