Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] fix: Initialize wallet connection status as unknown #6360

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Feb 27, 2025

Fixes #6143


PR-Codex overview

This PR focuses on modifying the ConnectionStatus type in the thirdweb package to include a new status, unknown, and initializing the activeWalletConnectionStatus to unknown instead of disconnected.

Detailed summary

  • Added unknown to the ConnectionStatus type.
  • Changed the initialization of activeWalletConnectionStatusStore from "disconnected" to "unknown".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 10:24am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 10:24am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 10:24am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 10:24am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 10:24am

Copy link

changeset-bot bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: 177a04f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges joaquim-verges changed the title [thirdweb] fix: Initialize wallet connection status as unknown [SDK] fix: Initialize wallet connection status as unknown Feb 27, 2025
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Feb 27, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.56 KB (0%) 932 ms (0%) 317 ms (-1.66% 🔽) 1.3 s
thirdweb (cjs) 124.42 KB (0%) 2.5 s (0%) 848 ms (+13.45% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 125 ms (+141.55% 🔺) 237 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 34 ms (+382.34% 🔺) 44 ms
thirdweb/react (minimal + tree-shaking) 19.35 KB (+0.03% 🔺) 388 ms (+0.03% 🔺) 83 ms (-20.19% 🔽) 470 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accountStatus first status should be connecting ?
1 participant