Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

srcset - invalid escape mode for urls #68

Open
getdatakick opened this issue Jan 16, 2023 · 0 comments
Open

srcset - invalid escape mode for urls #68

getdatakick opened this issue Jan 16, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@getdatakick
Copy link
Contributor

Urls in srcset are escaped using html mode:

srcset="{$imageUrl|escape:'html':'UTF-8'} 211w"

It should be escaped using url, otherwise we have problems with spaces in path:

srcset="{$imageUrl|escape:'url':'UTF-8'} 211w"
@getdatakick getdatakick added the bug Something isn't working label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@getdatakick