Skip to content
This repository has been archived by the owner on Apr 21, 2024. It is now read-only.

App crashes on open in production build when this library is installed. #102

Open
importTahsinZaman opened this issue Jun 29, 2023 · 12 comments

Comments

@importTahsinZaman
Copy link

The library works perfectly in Expo go and Development builds but causes my app to crash on open in a production build.

To reproduce the issue, just create an expo app (I am using managed workflow, typescript template,) install this library, create a production build:

eas build -p ios --profile preview --local

I have attached the crash log

crashlog.txt

@zwadzinski
Copy link

zwadzinski commented Jul 7, 2023

Same thing happened to me. When I try to push it to production with eas build it gives me a Run fastlane issue.

@importTahsinZaman
Copy link
Author

If you happened to be using this library just for the cropping feature, check out https://github.com/nitoba/expo-crop-image

That library forces the user to keep within an aspect ratio you define so I made my own fork of the library and that allows the user to crop without a fixed aspect ratio: https://www.npmjs.com/package/@tahsinz21366/expo-crop-image just set the aspect ratio prop to 777.

@zwadzinski
Copy link

zwadzinski commented Jul 8, 2023

Oh awesome thanks. The thing is when I was compiling with the original package at runtime using EAS it always failed to build. Will yours build properly? @importTahsinZaman

@importTahsinZaman
Copy link
Author

The original package would build for me. I didn't make any changes to my own package that would affect that but you can try mine regardless if you'd like.

@importTahsinZaman
Copy link
Author

I just reread your first message. That isn't the issue I was running into. My app would build fine with expo-image-editor, it would just then crash when downloaded via testflight.

@zwadzinski
Copy link

Ah ok mine would build and work fine on my phone when testing with "expo start" but when I tried to build it with "eas build" it would always fail when it gets to the fastlane part.

@fa2id
Copy link

fa2id commented Jul 8, 2023

@importTahsinZaman Do you know how we can use it as View instead of Modal?

@importTahsinZaman
Copy link
Author

@fa2id not sure what you're asking. Do you want the expo-crop-image editor to act as a view instead of a modal? I have not implemented a way to accomplish that but I imagine you could do that pretty easily, just look through the source code.

@fa2id
Copy link

fa2id commented Jul 8, 2023

Removed modal and gave z-index to the container.

Your code works for me on iOS, but the overlay doesn't move on Android. @importTahsinZaman Do you experience the same?

@importTahsinZaman
Copy link
Author

I have not yet tested on Android but I planning on doing so soon. Please let me know what you identify as the issue.

@fa2id
Copy link

fa2id commented Jul 8, 2023

So far, the crop overlay is fixed on the image and doesn't move on Android. If I find anything I'll update it here. LMK if you find something.

@fa2id
Copy link

fa2id commented Jul 8, 2023

Works on modal but view on Android

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants